From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Laurent Vivier" <lvivier@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems
Date: Wed, 30 Aug 2017 17:11:20 +0200 [thread overview]
Message-ID: <20170830171120.190439f5.cohuck@redhat.com> (raw)
In-Reply-To: <52928093-36d5-89cf-bb89-ab5abf54b8f0@redhat.com>
On Wed, 30 Aug 2017 16:59:03 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 30.08.2017 16:53, Philippe Mathieu-Daudé wrote:
> > On 08/30/2017 10:39 AM, Thomas Huth wrote:
> >> The "slow" ivshmem-tests currently fail when they are running on a
> >> big endian host:
> >>
> >> $ uname -m
> >> ppc64
> >> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
> >> tests/ivshmem-test -m slow
> >> /x86_64/ivshmem/single: OK
> >> /x86_64/ivshmem/hotplug: OK
> >> /x86_64/ivshmem/memdev: OK
> >> /x86_64/ivshmem/pair: OK
> >> /x86_64/ivshmem/server-msi: qemu-system-x86_64:
> >> -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid
> >> ID message
> >> Broken pipe
> >>
> >> The problem is that the server side code in ivshmem_server_send_one_msg()
> >> correctly translates all messages IDs into little endian 64-bit values,
> >> but the client side code in the ivshmem_recv_msg() function does not swap
> >> the byte order back. Fix it by passing the value through le64_to_cpu().
> >
> > Yes, we lack BE testing :(
>
> As far as I know, some people are already running the tests on s390x and
> ppc64 ... the problem is that apparently nobody is running with
> SPEED=slow there - that's why this problem slipped through so far.
> Maybe we should switch to the SPEED=slow by default in the Makefile?
Not sure whether that is a good idea. /me adding this to my s390x tests
should help, though.
next prev parent reply other threads:[~2017-08-30 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:39 [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems Thomas Huth
2017-08-30 14:13 ` Cornelia Huck
2017-08-30 14:48 ` Thomas Huth
2017-08-30 14:39 ` Marc-André Lureau
2017-08-30 14:53 ` Philippe Mathieu-Daudé
2017-08-30 14:59 ` Thomas Huth
2017-08-30 15:11 ` Cornelia Huck [this message]
2017-08-30 14:59 ` Peter Maydell
2017-09-10 3:24 ` David Gibson
2017-09-10 17:01 ` Philippe Mathieu-Daudé
2017-09-11 2:35 ` Thomas Huth
2017-09-11 7:29 ` Cornelia Huck
2017-09-14 7:44 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830171120.190439f5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.