All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Roger B Melton <rmelton@cisco.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org
Subject: Re: [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode
Date: Fri, 6 Oct 2017 09:54:04 +0100	[thread overview]
Message-ID: <20171006085403.GA24124@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20171005191111.27557-1-rmelton@cisco.com>

On Thu, Oct 05, 2017 at 03:11:11PM -0400, Roger B Melton wrote:
> ---
> 
> i40evf tx vector logic frees mbufs, but it does not remove the
> mbufs from software rings which leads to double frees.  This change
>  corrects that oversight.  We've validated this fix within our application.
> 

Hi Roger,

I'm a little concerned here by this driver fix, since if we are getting
double frees of mbufs there must be another bug somewhere in tracking
the free ring elements. Clearing the entries to NULL introduces extra
writes to the vector code path which will likely have a performance
impact, but also should be unnecessary, given proper tracking of the
ring status.

Can you provide us with some details as to how to reproduce the issue,
especially with a public sample app? I'd really like to look more into
why this is happening, and if other fixes may work.

Thanks,
/Bruce

  parent reply	other threads:[~2017-10-06  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 19:11 [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode Roger B Melton
2017-10-05 23:42 ` Roger B. Melton
2017-10-06  0:33   ` Ferruh Yigit
2017-10-06  8:54 ` Bruce Richardson [this message]
2017-10-06 12:38   ` Roger B. Melton
2017-10-06 13:51     ` Bruce Richardson
2017-10-06 14:06       ` Roger B. Melton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006085403.GA24124@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=rmelton@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.