All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
Subject: [PATCH v2 21/45] RDMA/i40iw: Suppress gcc 7 fall-through complaints
Date: Wed, 11 Oct 2017 10:49:03 -0700	[thread overview]
Message-ID: <20171011174927.25113-22-bart.vanassche@wdc.com> (raw)
In-Reply-To: <20171011174927.25113-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>

Avoid that gcc 7 reports the following warning when building with W=1:

warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
Reviewed-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/i40iw/i40iw_cm.c   | 1 +
 drivers/infiniband/hw/i40iw/i40iw_hw.c   | 1 +
 drivers/infiniband/hw/i40iw/i40iw_puda.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index 50c43766defd..4e1ff81c5ba0 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -2410,6 +2410,7 @@ static void i40iw_handle_rst_pkt(struct i40iw_cm_node *cm_node,
 	case I40IW_CM_STATE_FIN_WAIT1:
 	case I40IW_CM_STATE_LAST_ACK:
 		cm_node->cm_id->rem_ref(cm_node->cm_id);
+		/* fall through */
 	case I40IW_CM_STATE_TIME_WAIT:
 		cm_node->state = I40IW_CM_STATE_CLOSED;
 		i40iw_rem_ref_cm_node(cm_node);
diff --git a/drivers/infiniband/hw/i40iw/i40iw_hw.c b/drivers/infiniband/hw/i40iw/i40iw_hw.c
index 476867a3f584..7e9de845a350 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_hw.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_hw.c
@@ -410,6 +410,7 @@ void i40iw_process_aeq(struct i40iw_device *iwdev)
 		case I40IW_AE_UDA_XMIT_DGRAM_TOO_LONG:
 		case I40IW_AE_UDA_XMIT_IPADDR_MISMATCH:
 			ctx_info->err_rq_idx_valid = false;
+			/* fall through */
 		default:
 			if (!info->sq && ctx_info->err_rq_idx_valid) {
 				ctx_info->err_rq_idx = info->wqe_idx;
diff --git a/drivers/infiniband/hw/i40iw/i40iw_puda.c b/drivers/infiniband/hw/i40iw/i40iw_puda.c
index c2cab20c4bc5..2a3bf6488b4b 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_puda.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_puda.c
@@ -816,6 +816,7 @@ void i40iw_puda_dele_resources(struct i40iw_sc_vsi *vsi,
 	switch (rsrc->completion) {
 	case PUDA_HASH_CRC_COMPLETE:
 		i40iw_free_hash_desc(rsrc->hash_desc);
+		/* fall through */
 	case PUDA_QP_CREATED:
 		if (!reset)
 			i40iw_puda_free_qp(rsrc);
-- 
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-10-11 17:49 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 17:48 [PATCH v2 00/45] Address issues detected by static analysis tools Bart Van Assche
     [not found] ` <20171011174927.25113-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 17:48   ` [PATCH v2 01/45] IB/core: Fix endianness annotation in rdma_is_multicast_addr() Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 02/45] IB/cm: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 03/45] RDMA/cma: Avoid triggering undefined behavior Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 04/45] RDMA/iwcm: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 05/45] RDMA/isert: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 06/45] RDMA/bnxt_re: " Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 07/45] RDMA/bnxt_re: Remove set-but-not-used variables Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 08/45] RDMA/cxgb3: Annotate locking assumptions Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 09/45] RDMA/cxgb3: Annotate an RCU pointer Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 10/45] RDMA/cxgb3: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 11/45] RDMA/cxgb4: Fix indentation Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 12/45] RDMA/cxgb4: Remove the obsolete kernel module option 'c4iw_debug' Bart Van Assche
     [not found]     ` <20171011174927.25113-13-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 17:51       ` Steve Wise
2017-10-11 17:48   ` [PATCH v2 13/45] RDMA/cxgb4: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 14/45] RDMA/cxgb4: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 15/45] IB/hfi1: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 16/45] IB/hfi1: Remove set-but-not-used variables Bart Van Assche
2017-10-11 17:48   ` [PATCH v2 17/45] IB/hfi1: Define hfi1_handle_cnp_tbl[] once Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 18/45] IB/hns: Annotate iomem pointers correctly Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 19/45] IB/hns: Declare local functions 'static' Bart Van Assche
     [not found]     ` <20171011174927.25113-20-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-12  1:12       ` Wei Hu (Xavier)
2017-10-11 17:49   ` [PATCH v2 20/45] RDMA/i40iw: Fix a race condition Bart Van Assche
2017-10-11 17:49   ` Bart Van Assche [this message]
2017-10-11 17:49   ` [PATCH v2 22/45] RDMA/i40iw: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 23/45] IB/mthca: Fix indentation Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 24/45] IB/mlx4: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 25/45] IB/mlx5: " Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 26/45] IB/mlx5: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 27/45] IB/nes: Fix indentation Bart Van Assche
     [not found]     ` <20171011174927.25113-28-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 18:14       ` Latif, Faisal
2017-10-11 17:49   ` [PATCH v2 28/45] IB/nes: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171011174927.25113-29-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 18:11       ` Latif, Faisal
2017-10-11 17:49   ` [PATCH v2 29/45] IB/nes: Remove set-but-not-used variables Bart Van Assche
     [not found]     ` <20171011174927.25113-30-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 18:12       ` Latif, Faisal
2017-10-11 17:49   ` [PATCH v2 30/45] IB/nes: Fix a race condition in nes_inetaddr_event() Bart Van Assche
     [not found]     ` <20171011174927.25113-31-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 18:13       ` Latif, Faisal
2017-10-11 17:49   ` [PATCH v2 31/45] RDMA/ocrdma: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 32/45] RDMA/ocrdma: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 33/45] RDMA/ocrdma: Remove set-but-not-used variables Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 34/45] RDMA/qedr: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 35/45] RDMA/qedr: Declare local functions static Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 36/45] RDMA/qedr: Annotate iomem pointers correctly Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 37/45] RDMA/qedr: Remove set-but-not-used variables Bart Van Assche
     [not found]     ` <20171011174927.25113-38-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-15  7:52       ` Amrani, Ram
2017-10-11 17:49   ` [PATCH v2 38/45] IB/qib: Remove remaining code related to writing the EEPROM Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 39/45] IB/qib: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 40/45] IB/qib: Remove set-but-not-used variables Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 41/45] RDMA/rdmavt: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 42/45] RDMA/rxe: " Bart Van Assche
     [not found]     ` <20171011174927.25113-43-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-29  7:23       ` Moni Shoua
2017-10-11 17:49   ` [PATCH v2 43/45] RDMA/usnic: Make the compiler check declaration consistency during compilation Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 44/45] RDMA/usnic: Remove a set-but-not-used variable Bart Van Assche
2017-10-11 17:49   ` [PATCH v2 45/45] RDMA/usnic: Instantiate data structures once Bart Van Assche
2017-10-15  0:48   ` [PATCH v2 00/45] Address issues detected by static analysis tools Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011174927.25113-22-bart.vanassche@wdc.com \
    --to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.