From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: clean up btrfs_dev_stat_inc() usage
Date: Mon, 30 Oct 2017 13:51:11 +0100 [thread overview]
Message-ID: <20171030125111.GQ3521@twin.jikos.cz> (raw)
In-Reply-To: <20171020174533.7766-1-anand.jain@oracle.com>
On Sat, Oct 21, 2017 at 01:45:33AM +0800, Anand Jain wrote:
> btrfs_end_bio() is using btrfs_dev_stat_inc() and then
> btrfs_dev_stat_print_on_error() separately instead use
> btrfs_dev_stat_inc_and_print() directly.
>
> As of now there isn't any bio in btrfs which is - a non-empty write and
> also the REQ_PREFLUSH flag is set. So in actual the condition
> if (bio->bi_opf & REQ_PREFLUSH)
> is never true in btrfs_end_bio(), and so there won't be any redundant error
> log by using btrfs_dev_stat_inc_and_print() separately one for write and
> another for flush.
>
> This consolidation will help to add the device critical error handles in the
> function btrfs_dev_stat_inc_and_print() and which can be renamed as needed.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2017-10-30 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 9:50 [PATCH] btrfs: clean up btrfs_dev_stat_inc() usage Anand Jain
2017-10-20 11:48 ` Nikolay Borisov
2017-10-20 15:27 ` David Sterba
2017-10-20 17:34 ` Anand Jain
2017-10-20 17:45 ` [PATCH v2] " Anand Jain
2017-10-30 12:51 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030125111.GQ3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.