From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, glauber@scylladb.com
Subject: Re: [PATCH v2 2/2] mm,vmscan: Mark register_shrinker() as __must_check
Date: Fri, 24 Nov 2017 22:26:03 +0900 [thread overview]
Message-ID: <201711242226.BAC04642.FHOFSOLtOJVFMQ@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20171124122410.s7lyzfmkhlm6awes@dhcp22.suse.cz>
Michal Hocko wrote:
> As already pointed out, I do not think this is worth it. This function
> is no different than many others which need error handling. The system
> will work suboptimally when the shrinker is missing, no question about
> that, but there is no immediate blow up otherwise. It is not all that
> hard to find all those places and fix them up. We do not have hundreds
> of them...
The system might blow up after two years of uptime. For enterprise systems
which try to avoid reboots as much as possible, it is important to fix
known bugs before deploying.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-24 13:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 11:36 [PATCH v2 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed Tetsuo Handa
2017-11-24 11:36 ` [PATCH v2 2/2] mm,vmscan: Mark register_shrinker() as __must_check Tetsuo Handa
2017-11-24 12:24 ` Michal Hocko
2017-11-24 13:26 ` Tetsuo Handa [this message]
2017-11-24 13:37 ` Michal Hocko
2017-11-24 12:21 ` [PATCH v2 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed Michal Hocko
2017-11-24 13:21 ` Tetsuo Handa
2017-11-24 13:28 ` Michal Hocko
2017-11-25 1:40 ` Tetsuo Handa
2017-11-27 8:29 ` Michal Hocko
2017-11-29 13:44 ` Tetsuo Handa
2017-11-29 13:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711242226.BAC04642.FHOFSOLtOJVFMQ@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=glauber@scylladb.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.