From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Teddy Wang" <teddy.wang@siliconmotion.com>,
"David Airlie" <airlied@linux.ie>,
"Greg KH" <gregkh@linuxfoundation.org>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()
Date: Mon, 11 Dec 2017 21:57:00 +0000 [thread overview]
Message-ID: <20171211215700.GA4899@sudip-laptop> (raw)
In-Reply-To: <CACvgo52NmpWv4DdwMuu3b9fZx++Wd2zvCvtvN75LxPqmycpCtQ@mail.gmail.com>
Hi Emil,
On Fri, Dec 01, 2017 at 02:40:11PM +0000, Emil Velikov wrote:
> On 30 November 2017 at 23:49, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > Hi Daniel,
> >
> > On Wed, Nov 29, 2017 at 10:56:34AM +0100, Daniel Vetter wrote:
<snip>
> > submit it to dri-devel.
> >
> A crazy idea, mostly towards Tedd and Sudip:
>
> Start small and build gradually. An example split for separate patch series:
>
> - one HW, basic setup + atomic KMS
> - add second HW
> - more KMS features
> - fancy memory management
> - 2D/3D/other acceleration
>
> The driver as seen above tries to do all of the above (almost, it's not atomic)
> at once - 40k loc.
>
> Someone familiar with the code can quickly split it up and while doing
> so, feed it through checkpatch.
I can try but will be very tough since I have to go through the code to
get familiar with it and, as mentioned before, its not part of my dayjob,
so time will be a problem. Developing from scratch takes much more time
than fixing something.
> Current code is _very_ far from kernel coding style, plus the
> copyright blurp is very disturbing:
I will fix the coding style before my first submission to dri-devel,
which should be in January after I have setup my desktop with the
hardware for testing.
The copyright thing - I am sure Teddy can talk to his company and will
confirm that we can change it to the way kernel code is done.
--
Regards
Sudip
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-12-11 21:57 UTC|newest]
Thread overview: 191+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 17:53 [PATCH 00/13] remove_conflicting_framebuffers() cleanup Michał Mirosław
2017-11-24 17:53 ` [PATCH 01/13] fbdev: show fbdev number for debugging Michał Mirosław
2017-11-24 17:53 ` [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
[not found] ` <1738dbed0239bffc886f126fd3091daa39cd14c9.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-27 10:27 ` Daniel Vetter
2017-11-27 20:52 ` Sudip Mukherjee
2017-11-27 20:52 ` Sudip Mukherjee
2017-11-28 10:22 ` Daniel Vetter
2017-11-28 11:32 ` Greg KH
2017-11-28 12:30 ` Sudip Mukherjee
2017-11-28 13:06 ` Greg KH
2017-11-29 9:56 ` Daniel Vetter
2017-11-30 23:49 ` Sudip Mukherjee
2017-11-30 23:49 ` Sudip Mukherjee
2017-12-01 7:19 ` Daniel Vetter
2017-12-01 14:10 ` Sudip Mukherjee
2017-12-01 7:19 ` Daniel Vetter
2017-12-01 14:40 ` Emil Velikov
2017-12-01 14:40 ` Emil Velikov
2017-12-11 21:57 ` Sudip Mukherjee
2017-12-11 21:57 ` Sudip Mukherjee [this message]
2017-11-29 9:56 ` Daniel Vetter
2017-11-28 12:30 ` Sudip Mukherjee
2017-11-28 11:32 ` Greg KH
2017-11-28 10:22 ` Daniel Vetter
2017-11-27 10:27 ` Daniel Vetter
2017-11-24 17:53 ` [PATCH 06/13] drm/mgag200: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2017-11-24 17:53 ` [PATCH 05/13] drm/cirrus: " Michał Mirosław
2017-11-24 17:53 ` [PATCH 04/13] drm/bochs: " Michał Mirosław
2017-11-24 17:53 ` [PATCH 09/13] staging: sm750fb: " Michał Mirosław
2017-11-27 10:25 ` Daniel Vetter
2017-11-27 20:57 ` Sudip Mukherjee
2017-11-24 17:53 ` [PATCH 08/13] drm/virtio: " Michał Mirosław
2017-11-24 17:53 ` [PATCH 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2017-11-28 20:11 ` Eric Anholt
[not found] ` <cover.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-24 17:53 ` [PATCH 03/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2017-11-27 15:27 ` Alex Deucher
2017-11-24 17:53 ` [PATCH 07/13] drm/radeon: " Michał Mirosław
2017-11-24 17:53 ` [PATCH 10/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
[not found] ` <13240c59cafec988cdda37cc4d48252ff56f0d04.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-27 10:29 ` Daniel Vetter
2017-11-24 17:53 ` [PATCH 13/13] drm/tegra: kick out simplefb Michał Mirosław
[not found] ` <89e22ee1c026b40a5bfa91de282d658b56dc8ee8.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-24 20:50 ` Thierry Reding
2017-11-24 21:42 ` Michał Mirosław
2017-11-24 17:53 ` [PATCH 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2017-11-27 7:26 ` Maxime Ripard
2017-11-27 10:30 ` [PATCH 00/13] remove_conflicting_framebuffers() cleanup Daniel Vetter
2017-11-27 10:30 ` Daniel Vetter
2017-11-27 10:33 ` Thierry Reding
2018-01-03 15:04 ` Bartlomiej Zolnierkiewicz
[not found] ` <20171127103044.faakzch7ehlkc3or-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-11-27 10:33 ` Thierry Reding
2018-01-03 15:04 ` Bartlomiej Zolnierkiewicz
2018-08-30 21:00 ` [PATCH v2 00/12] " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 01/12] fbdev: show fbdev number for debugging Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-31 8:56 ` Daniel Vetter
2018-08-31 8:56 ` Daniel Vetter
2018-08-31 8:56 ` Daniel Vetter
[not found] ` <20180831085656.GR21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-08-31 9:01 ` Daniel Vetter
2018-08-31 9:01 ` Daniel Vetter
2018-08-31 9:01 ` Daniel Vetter
2018-08-31 9:01 ` Daniel Vetter
2018-08-30 21:00 ` [PATCH v2 01/12] fbdev: show fbdev number for debugging Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 03/12] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 04/12] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 03/12] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 04/12] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 06/12] drm/cirrus: " Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 05/12] drm/bochs: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 06/12] drm/cirrus: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 05/12] drm/bochs: " Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 08/12] drm/radeon: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 07/12] drm/mgag200: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 09/12] drm/virtio: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 10/12] drm/vc4: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 11/12] drm/sun4i: " Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` [PATCH v2 12/12] drm/tegra: kick out simplefb Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-30 21:00 ` Michał Mirosław
2018-08-31 9:04 ` [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup Daniel Vetter
2018-08-31 9:04 ` Daniel Vetter
2018-08-31 9:04 ` Daniel Vetter
2018-08-31 9:07 ` Chris Wilson
[not found] ` <20180831090439.GT21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-08-31 9:07 ` Chris Wilson
2018-08-31 9:07 ` Chris Wilson
2018-08-31 9:07 ` Chris Wilson
2018-09-01 13:45 ` Michał Mirosław
2018-09-01 13:45 ` Michał Mirosław
2018-09-01 13:45 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 00/13] " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 02/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 01/13] fbdev: show fbdev number for debugging Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-03 16:16 ` Daniel Vetter
2018-09-03 16:16 ` Daniel Vetter
2018-09-03 16:16 ` Daniel Vetter
2018-09-04 15:40 ` kbuild test robot
2018-09-04 15:40 ` kbuild test robot
2018-09-04 15:40 ` kbuild test robot
2018-09-04 15:40 ` kbuild test robot
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 03/13] fbdev: add kerneldoc do remove_conflicting_framebuffers() Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
[not found] ` <283fef19815b991700b56119d8d5874a2a8da44e.1535810304.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2018-09-05 11:02 ` Paul Menzel
2018-09-05 11:02 ` Paul Menzel
2018-09-05 11:02 ` Paul Menzel
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 05/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 06/13] drm/bochs: " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 07/13] drm/cirrus: " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 08/13] drm/mgag200: " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 09/13] drm/radeon: " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 08/13] drm/mgag200: " Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 10/13] drm/virtio: " Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 13/13] drm/tegra: kick out simplefb Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 13/13] drm/tegra: kick out simplefb Michał Mirosław
2018-09-01 14:08 ` [PATCH v3 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
[not found] ` <cover.1535810304.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2018-09-03 7:43 ` [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Daniel Vetter
2018-09-03 7:43 ` Daniel Vetter
2018-09-03 7:43 ` Daniel Vetter
2018-09-03 11:31 ` Bartlomiej Zolnierkiewicz
[not found] ` <20180903074315.GB21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-09-03 11:31 ` Bartlomiej Zolnierkiewicz
2018-09-03 11:31 ` Bartlomiej Zolnierkiewicz
2018-09-03 11:31 ` Bartlomiej Zolnierkiewicz
2018-09-03 16:26 ` Daniel Vetter
2018-09-03 16:26 ` Daniel Vetter
2018-09-03 16:26 ` Daniel Vetter
2018-09-03 16:26 ` Daniel Vetter
2018-09-03 7:43 ` Daniel Vetter
2018-08-30 21:00 ` [PATCH v2 00/12] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211215700.GA4899@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kraxel@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=teddy.wang@siliconmotion.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.