From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, mreitz@redhat.com,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/7] blockjob: refactor mirror_throttle
Date: Wed, 13 Dec 2017 19:59:46 -0500 [thread overview]
Message-ID: <20171214005953.8898-1-jsnow@redhat.com> (raw)
mirror_throttle attempts to make sure we yield every so often when we're
doing operations that may not otherwise be as cooperative as we'd like.
This pattern is useful to other jobs like commit as well; if commit
continuously decides not to copy data (and calculates delay_ns to be 0),
we'll frequently and aggressively yield, only to be rescheduled immediately.
This causes those "WARNING: I/O thread spun for 1000 iterations"
warnings that everyone loves so much.
Split out the mirror_throttle function to become a new internal
BlockJob API function, block_job_throttle; then use it for all
the other jobs in their runtime loops.
I decided to use it in stream and backup as well, so that regardless of if the
loop structure has the chance to be greedy or not (I did not audit this), the
BlockJob has some kind of failsafe that will occasionally perform a 0ns sleep
every SLICE_TIME.
________________________________________________________________________________
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch block-job-yield
https://github.com/jnsnow/qemu/tree/block-job-yield
This version is tagged block-job-yield-v1:
https://github.com/jnsnow/qemu/releases/tag/block-job-yield-v1
John Snow (7):
blockjob: record time of last yield
blockjob: consolidate SLICE_TIME definition
blockjob: create block_job_throttle
blockjob: allow block_job_throttle to take delay_ns
block/commit: use block_job_throttle
block/stream: use block_job_throttle
block/backup: use block_job_throttle
block/backup.c | 12 ++++++------
block/commit.c | 5 ++---
block/mirror.c | 22 +++-------------------
block/stream.c | 4 +---
blockjob.c | 12 ++++++++++++
include/block/blockjob.h | 5 +++++
include/block/blockjob_int.h | 15 +++++++++++++++
7 files changed, 44 insertions(+), 31 deletions(-)
--
2.14.3
next reply other threads:[~2017-12-14 1:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 0:59 John Snow [this message]
2017-12-14 0:59 ` [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield John Snow
2017-12-14 8:38 ` Paolo Bonzini
2017-12-14 15:55 ` John Snow
2017-12-18 14:22 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition John Snow
2017-12-14 8:51 ` Paolo Bonzini
2017-12-18 14:23 ` Stefan Hajnoczi
2018-01-02 20:29 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle John Snow
2017-12-14 8:39 ` Paolo Bonzini
2017-12-14 15:57 ` John Snow
2017-12-18 14:27 ` Stefan Hajnoczi
2018-01-02 21:23 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns John Snow
2017-12-14 8:49 ` Paolo Bonzini
2017-12-14 16:06 ` John Snow
2017-12-14 17:21 ` Paolo Bonzini
2017-12-14 17:22 ` John Snow
2017-12-14 17:23 ` Paolo Bonzini
2017-12-14 0:59 ` [Qemu-devel] [PATCH 5/7] block/commit: use block_job_throttle John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 6/7] block/stream: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 7/7] block/backup: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214005953.8898-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.