All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature
Date: Wed, 20 Dec 2017 19:40:10 +0900	[thread overview]
Message-ID: <20171220104010.GC32243@lianli.shorne-pla.net> (raw)
In-Reply-To: <837etiptz2.fsf@gnu.org>

On Tue, Dec 19, 2017 at 06:23:29PM +0200, Eli Zaretskii wrote:
> > From: Stafford Horne <shorne@gmail.com>
> > Cc: Openrisc <openrisc@lists.librecores.org>,	Stafford Horne <shorne@gmail.com>
> > Date: Tue, 19 Dec 2017 23:22:54 +0900
> > 
> > Until now this feature has existed but was not documented.  Adding docs
> > and tests.
> 
> Thanks!
> 
> > + at item info registers @var{reggroup} @dots{}
> > +Print the name and value of the registers in each of the specified
> > + at var{reggroup}.  The @var{reggoup} can be any of those returned by
> 
> Please use "@var{reggroup}s", with the trailing "s", otherwise this is
> not correct English.

OK.

> > + at code{maint print reggroups}.

OK.

> Please add here a cross-reference to the node where "maint print
> reggroups" is described.
> 
> >    c = add_info ("registers", info_registers_command, _("\
> >  List of integer registers and their contents, for selected stack frame.\n\
> > -Register name as argument means describe only that register."));
> > +Register name as argument means describe only that register.\n\
> > +Register group name as argument means describe the registers in the\n\
> > +named register group."));
> 
> Since this command accepts more than one reggroup, I think the doc
> string should mention that.

OK.

> The documentation parts are okay with these nits fixed.

Thank you.

-Stafford

  reply	other threads:[~2017-12-20 10:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 14:22 [OpenRISC] [PATCH v3 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-19 14:22 ` [OpenRISC] [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-19 16:23   ` Eli Zaretskii
2017-12-20 10:40     ` Stafford Horne [this message]
2017-12-21  2:40     ` Simon Marchi
2017-12-21  3:40       ` Eli Zaretskii
2017-12-21  2:58   ` Simon Marchi
2017-12-24 14:47     ` Stafford Horne
2017-12-19 14:22 ` [OpenRISC] [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-21  3:03   ` Simon Marchi
2017-12-19 14:22 ` [OpenRISC] [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups Stafford Horne
2017-12-21  3:15   ` Simon Marchi
2017-12-19 14:22 ` [OpenRISC] [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-19 16:27   ` Eli Zaretskii
2017-12-19 22:13     ` Stafford Horne
2017-12-20 13:34       ` Stafford Horne
2017-12-20 15:53       ` Eli Zaretskii
2017-12-21  3:29   ` Simon Marchi
2017-12-21 12:55     ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220104010.GC32243@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.