From: Keith Busch <keith.busch@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG 4.15-rc7] IRQ matrix management errors
Date: Tue, 16 Jan 2018 00:11:45 -0700 [thread overview]
Message-ID: <20180116071145.GA5643@localhost.localdomain> (raw)
In-Reply-To: <20180116061641.GB32639@localhost.localdomain>
This is all way over my head, but the part that obviously shows
something's gone wrong:
kworker/u674:3-1421 [028] d... 335.307051: irq_matrix_reserve_managed: bit=56 cpu=0 online=1 avl=86 alloc=116 managed=3 online_maps=112 global_avl=22084, global_rsvd=157, total_alloc=570
kworker/u674:3-1421 [028] d... 335.307053: irq_matrix_remove_managed: bit=56 cpu=0 online=1 avl=87 alloc=116 managed=2 online_maps=112 global_avl=22085, global_rsvd=157, total_alloc=570
kworker/u674:3-1421 [028] .... 335.307054: vector_reserve_managed: irq=45 ret=-28
kworker/u674:3-1421 [028] .... 335.307054: vector_setup: irq=45 is_legacy=0 ret=-28
kworker/u674:3-1421 [028] d... 335.307055: vector_teardown: irq=45 is_managed=1 has_reserved=0
Which leads me to x86_vector_alloc_irqs goto error:
error:
x86_vector_free_irqs(domain, virq, i + 1);
The last parameter looks weird. It's the nr_irqs, and since we failed and
bailed, I would think we'd need to subtract 1 rather than add 1. Adding
1 would doublely remove the failed one, and remove the next one that
was never setup, right?
Or maybe irq_matrix_reserve_managed wasn't expected to fail in the
first place?
next prev parent reply other threads:[~2018-01-16 7:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180115025759.GG13580@localhost.localdomain>
2018-01-15 3:02 ` [BUG 4.15-rc7] IRQ matrix management errors Keith Busch
2018-01-15 9:13 ` Thomas Gleixner
2018-01-16 6:16 ` Keith Busch
2018-01-16 7:11 ` Keith Busch [this message]
2018-01-16 10:33 ` Thomas Gleixner
2018-01-16 11:20 ` Thomas Gleixner
2018-01-16 14:26 ` Keith Busch
2018-01-17 2:25 ` Keith Busch
2018-01-17 7:34 ` Thomas Gleixner
2018-01-17 7:55 ` Keith Busch
2018-01-17 9:24 ` Thomas Gleixner
2018-01-17 9:32 ` Thomas Gleixner
2018-01-17 14:24 ` Keith Busch
2018-01-17 15:01 ` Thomas Gleixner
2018-01-18 2:37 ` Keith Busch
2018-01-18 8:10 ` Thomas Gleixner
2018-01-18 8:48 ` Keith Busch
2018-01-18 9:06 ` Thomas Gleixner
2018-01-18 10:43 ` [tip:irq/urgent] irq/matrix: Spread interrupts on allocation tip-bot for Thomas Gleixner
2018-01-17 11:15 ` [tip:x86/urgent] x86/apic/vector: Fix off by one in error path tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116071145.GA5643@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.