[U-Boot] [U-Boot, 1/4] serial: ns16550: da8xx (freon/primus) is not omap-like

From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/4] serial: ns16550: da8xx (freon/primus) is not omap-like
Date: Fri, 19 Jan 2018 10:26:50 -0500	[thread overview]
Message-ID: <20180119152650.GA23609@bill-the-cat> (raw)
In-Reply-To: <20180108125059.GA14025@squirrel.local>

On Mon, Jan 08, 2018 at 01:50:59PM +0100, Matthijs van Duin wrote:

> These are SoCs in the lineage of TI C6x DSPs, and as such have the same
> uart as TI Keystone SoCs.
> 
> Signed-off-by: Matthijs van Duin <matthijsvanduin@gmail.com>
> ---
>  drivers/serial/ns16550.c | 8 ++++----
>  include/ns16550.h        | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index c702304e79bd..9cec58c887c8 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -36,7 +36,7 @@ DECLARE_GLOBAL_DATA_PTR;
>  #endif
>  #endif /* !CONFIG_DM_SERIAL */
>  
> -#if defined(CONFIG_SOC_KEYSTONE)
> +#if defined(CONFIG_SOC_KEYSTONE) || defined(CONFIG_SOC_DA8XX)
>  #define UART_REG_VAL_PWREMU_MGMT_UART_DISABLE   0
>  #define UART_REG_VAL_PWREMU_MGMT_UART_ENABLE ((1 << 14) | (1 << 13) | (1 << 0))
>  #undef UART_MCRVAL
> @@ -181,12 +181,12 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
>  	serial_out(ns16550_getfcr(com_port), &com_port->fcr);
>  	if (baud_divisor != -1)
>  		NS16550_setbrg(com_port, baud_divisor);
> -#if defined(CONFIG_ARCH_OMAP2PLUS) || defined(CONFIG_SOC_DA8XX)
> +#if defined(CONFIG_ARCH_OMAP2PLUS)
>  	/* /16 is proper to hit 115200 with 48MHz */
>  	serial_out(0, &com_port->mdr1);
>  #endif
> -#if defined(CONFIG_SOC_KEYSTONE)
> -	serial_out(UART_REG_VAL_PWREMU_MGMT_UART_ENABLE, &com_port->regC);
> +#if defined(CONFIG_SOC_KEYSTONE) || defined(CONFIG_SOC_DA8XX)
> +	serial_out(UART_REG_VAL_PWREMU_MGMT_UART_ENABLE, &com_port->pwr_mgmt);
>  #endif
>  }

This introduces a warning on all SOC_DA8XX systems because they do not
set CONFIG_SYS_NS16550_MEM32 so serial_out is writeb and
UART_REG_VAL_PWREMU_MGMT_UART_ENABLE is larger than a u8.  Are you able
to test SOC_DA8XX platforms?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/544e1e8e/attachment.sig>