From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/entry/64: use xorl for register clearing
Date: Wed, 14 Feb 2018 19:27:16 +0100 [thread overview]
Message-ID: <20180214182716.GA5918@isilmar-4.linta.de> (raw)
In-Reply-To: <20180214182112.GA29859@avx2>
On Wed, Feb 14, 2018 at 09:21:12PM +0300, Alexey Dobriyan wrote:
> > - xorq %r8, %r8 /* nospec r8 */
> > + xorl %r8d, %r8d /* nospec r8 */
>
> The suffix should be simply dropped as operand size is unambigious.
> It is just one more character than necessary on the screen.
No strong feelings about this issue, but I prefer it to be explicit. And
that's what seems to be the standard in arch/x86/entry/ .
Thanks,
Dominik
next prev parent reply other threads:[~2018-02-14 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 18:21 [PATCH 2/2] x86/entry/64: use xorl for register clearing Alexey Dobriyan
2018-02-14 18:27 ` Dominik Brodowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-14 17:59 [PATCH 0/2] x86/entry: xorq->xorl; idtentry size reduction Dominik Brodowski
2018-02-14 17:59 ` [PATCH 2/2] x86/entry/64: use xorl for register clearing Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214182716.GA5918@isilmar-4.linta.de \
--to=linux@dominikbrodowski.net \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.