From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 3/3] ndctl: add filtering based on numa_node
Date: Wed, 7 Mar 2018 11:46:21 -0700 [thread overview]
Message-ID: <20180307184621.GA14531@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4gSMyVRbVNRubtdQ7_mrY8NpKWwx0p1vdz6j1KLGssSEw@mail.gmail.com>
On Wed, Mar 07, 2018 at 10:36:47AM -0800, Dan Williams wrote:
> > @@ -342,6 +372,10 @@ int util_filter_walk(struct ndctl_ctx *ctx, struct util_filter_ctx *fctx,
> > param->namespace))
> > continue;
> >
> > + if (numa_node != -1 &&
> > + ndctl_region_get_numa_node(region) != numa_node)
> > + continue;
>
> Maybe "numa_node >= 0", or "#define NUMA_NO_NODE (-1)" and use that?
Yea, that does make it easier to read. Thanks for the review.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-03-07 18:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 18:02 [PATCH 1/3] ndctl: don't print erroneous namespace numa_nodes Ross Zwisler
2018-03-07 18:02 ` [PATCH 2/3] ndctl: add numa_node support for regions Ross Zwisler
2018-03-07 18:25 ` Dan Williams
2018-03-07 18:02 ` [PATCH 3/3] ndctl: add filtering based on numa_node Ross Zwisler
2018-03-07 18:36 ` Dan Williams
2018-03-07 18:46 ` Ross Zwisler [this message]
2018-03-07 18:53 ` [PATCH v2 " Ross Zwisler
2018-03-07 19:00 ` Dan Williams
2018-03-07 20:42 ` Verma, Vishal L
2018-03-07 20:48 ` Dan Williams
2018-03-07 20:50 ` Verma, Vishal L
2018-03-08 17:21 ` Ross Zwisler
2018-03-08 17:50 ` Dan Williams
2018-03-08 21:08 ` Vishal Verma
2018-03-08 23:57 ` Ross Zwisler
2018-03-08 23:02 ` [PATCH v3 3/3] ndctl: add filtering based on numa node Ross Zwisler
2018-03-07 18:23 ` [PATCH 1/3] ndctl: don't print erroneous namespace numa_nodes Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307184621.GA14531@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.