From: Alexander Duyck <alexander.h.duyck@intel.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com,
niranjana.vishwanathapura@intel.com, tariqt@mellanox.com
Subject: [PATCH 2/3] mlx4: Don't bother using skb_tx_hash in mlx4_en_select_queue
Date: Fri, 27 Apr 2018 14:06:45 -0400 [thread overview]
Message-ID: <20180427180640.4883.75746.stgit@ahduyck-green-test.jf.intel.com> (raw)
In-Reply-To: <20180427180142.4883.96259.stgit@ahduyck-green-test.jf.intel.com>
The code in the fallback path has supported XDP in conjunction with the Tx
traffic classification for TCs for over a year now. So instead of just
calling skb_tx_hash for every packet we are better off using the fallback
since that will record the Tx queue to the socket and then that can be used
instead of having to recompute the hash every time.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 6b68537..0227786 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -694,7 +694,7 @@ u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb,
u16 rings_p_up = priv->num_tx_rings_p_up;
if (netdev_get_num_tc(dev))
- return skb_tx_hash(dev, skb);
+ return fallback(dev, skb);
return fallback(dev, skb) % rings_p_up;
}
next prev parent reply other threads:[~2018-04-27 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 18:06 [PATCH 0/3] Clean up users of skb_tx_hash and __skb_tx_hash Alexander Duyck
2018-04-27 18:06 ` [PATCH 1/3] opa_vnic: Just use skb_get_hash instead of skb_tx_hash Alexander Duyck
2018-04-27 18:06 ` Alexander Duyck [this message]
2018-05-02 18:09 ` [PATCH 2/3] mlx4: Don't bother using skb_tx_hash in mlx4_en_select_queue Ruhl, Michael J
2018-05-02 20:20 ` Alexander Duyck
2018-04-27 18:06 ` [PATCH 3/3] net: Revoke export for __skb_tx_hash, update it to just be static skb_tx_hash Alexander Duyck
2018-04-30 2:01 ` [PATCH 0/3] Clean up users of skb_tx_hash and __skb_tx_hash David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427180640.4883.75746.stgit@ahduyck-green-test.jf.intel.com \
--to=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niranjana.vishwanathapura@intel.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.