From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH 1/2] net/mlx5: fix socket connection return
	value
Date: Wed, 2 May 2018 08:50:56 +0200
Message-ID: <20180502065056.cfvwd3j52s2paxpg@laranjeiro-vm.dev.6wind.com>
References: <20180501111806.112319-1-shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 987EB126B
 for <dev@dpdk.org>; Wed,  2 May 2018 08:49:51 +0200 (CEST)
Received: by mail-wm0-f65.google.com with SMTP id j5so22295607wme.5
 for <dev@dpdk.org>; Tue, 01 May 2018 23:49:51 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180501111806.112319-1-shahafs@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 01, 2018 at 02:18:05PM +0300, Shahaf Shuler wrote:
> Upon success, mlx5_socket_connect should return the fd descriptor of the
> primary process
> 
> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  drivers/net/mlx5/mlx5.c        | 2 +-
>  drivers/net/mlx5/mlx5_socket.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 8f983061a0..46cb370a29 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -804,7 +804,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
>  				goto error;
>  			/* Receive command fd from primary process */
>  			err = mlx5_socket_connect(eth_dev);
> -			if (err)
> +			if (err < 0)
>  				goto error;
>  			/* Remap UAR for Tx queues. */
>  			err = mlx5_tx_uar_remap(eth_dev, err);
> diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
> index e12c4cb2e1..99297d5c43 100644
> --- a/drivers/net/mlx5/mlx5_socket.c
> +++ b/drivers/net/mlx5/mlx5_socket.c
> @@ -294,7 +294,7 @@ mlx5_socket_connect(struct rte_eth_dev *dev)
>  	}
>  	ret = *fd;
>  	close(socket_fd);
> -	return 0;
> +	return ret;
>  error:
>  	if (socket_fd != -1)
>  		close(socket_fd);
> -- 
> 2.12.0
> 

-- 
Nélio Laranjeiro
6WIND