All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [Qemu-devel] [PATCH v8 10/24] migration: wakeup dst ram-load-thread for recover
Date: Wed,  2 May 2018 18:47:26 +0800	[thread overview]
Message-ID: <20180502104740.12123-11-peterx@redhat.com> (raw)
In-Reply-To: <20180502104740.12123-1-peterx@redhat.com>

On the destination side, we cannot wake up all the threads when we got
reconnected. The first thing to do is to wake up the main load thread,
so that we can continue to receive valid messages from source again and
reply when needed.

At this point, we switch the destination VM state from postcopy-paused
back to postcopy-recover.

Now we are finally ready to do the resume logic.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.c | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 304e8bf2af..32f6d686b7 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -440,8 +440,34 @@ static void migration_incoming_process(void)
 
 void migration_fd_process_incoming(QEMUFile *f)
 {
-    migration_incoming_setup(f);
-    migration_incoming_process();
+    MigrationIncomingState *mis = migration_incoming_get_current();
+
+    if (mis->state == MIGRATION_STATUS_POSTCOPY_PAUSED) {
+        /* Resumed from a paused postcopy migration */
+
+        mis->from_src_file = f;
+        /* Postcopy has standalone thread to do vm load */
+        qemu_file_set_blocking(f, true);
+
+        /* Re-configure the return path */
+        mis->to_src_file = qemu_file_get_return_path(f);
+
+        migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_PAUSED,
+                          MIGRATION_STATUS_POSTCOPY_RECOVER);
+
+        /*
+         * Here, we only wake up the main loading thread (while the
+         * fault thread will still be waiting), so that we can receive
+         * commands from source now, and answer it if needed. The
+         * fault thread will be woken up afterwards until we are sure
+         * that source is ready to reply to page requests.
+         */
+        qemu_sem_post(&mis->postcopy_pause_sem_dst);
+    } else {
+        /* New incoming migration */
+        migration_incoming_setup(f);
+        migration_incoming_process();
+    }
 }
 
 void migration_ioc_process_incoming(QIOChannel *ioc)
-- 
2.14.3

  parent reply	other threads:[~2018-05-02 10:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 10:47 [Qemu-devel] [PATCH v8 00/24] Migration: postcopy failure recovery Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 01/24] migration: let incoming side use thread context Peter Xu
2018-05-08 14:36   ` Juan Quintela
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 02/24] migration: new postcopy-pause state Peter Xu
2018-05-08 15:16   ` Juan Quintela
2018-05-09  4:05     ` Peter Xu
2018-05-09  6:59       ` Juan Quintela
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 03/24] migration: implement "postcopy-pause" src logic Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 04/24] migration: allow dst vm pause on postcopy Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 05/24] migration: allow src return path to pause Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 06/24] migration: allow fault thread " Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 07/24] qmp: hmp: add migrate "resume" option Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 08/24] migration: rebuild channel on source Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 09/24] migration: new state "postcopy-recover" Peter Xu
2018-05-02 10:47 ` Peter Xu [this message]
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 11/24] migration: new cmd MIG_CMD_RECV_BITMAP Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 12/24] migration: new message MIG_RP_MSG_RECV_BITMAP Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 13/24] migration: new cmd MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 14/24] migration: new message MIG_RP_MSG_RESUME_ACK Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 15/24] migration: introduce SaveVMHandlers.resume_prepare Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 16/24] migration: synchronize dirty bitmap for resume Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 17/24] migration: setup ramstate " Peter Xu
2018-05-08 10:54   ` Dr. David Alan Gilbert
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 18/24] migration: final handshake for the resume Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 19/24] migration: init dst in migration_object_init too Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 20/24] qmp/migration: new command migrate-recover Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 21/24] hmp/migration: add migrate_recover command Peter Xu
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 22/24] migration: introduce lock for to_dst_file Peter Xu
2018-05-08 11:31   ` Dr. David Alan Gilbert
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 23/24] migration/qmp: add command migrate-pause Peter Xu
2018-05-08 13:20   ` Dr. David Alan Gilbert
2018-05-02 10:47 ` [Qemu-devel] [PATCH v8 24/24] migration/hmp: add migrate_pause command Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502104740.12123-11-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=aarcange@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.