From: Dirk Hohndel <dirk@hohndel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Thomas Hellstrom" <thellstrom@vmware.com>,
"Christian König" <christian.koenig@amd.com>,
"DRI mailing list" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] Add SPDX idenitifier and clarify license
Date: Thu, 3 May 2018 17:48:43 +0200 [thread overview]
Message-ID: <20180503154843.GG1309@rrmbpvm.gr8dns.org> (raw)
In-Reply-To: <CAOMZO5Dd5Gd3s_ai-NZzkC_GzJrr9fAK2Z6Ha5j7xcOzAUh_Zg@mail.gmail.com>
On Thu, May 03, 2018 at 10:03:32AM -0300, Fabio Estevam wrote:
> On Wed, May 2, 2018 at 10:46 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>
> > diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > index 7c2485fe88d8..ea4d59eb8966 100644
> > --- a/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > +++ b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > @@ -1,3 +1,4 @@
> > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
>
> According to Documentation/process/license-rules.rst the SPDX tag
> should start with // in .c files.
I saw that... but looking at what's there in C code:
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.c: | cut -d: -f2 | sort | grep ^// | wc
5260 10519 142020
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.c: | cut -d: -f2 | sort | grep ^/\* | wc
5397 10792 145680
(ok, that's close...)
But if you do the same analysis for header files...
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.h: | cut -d: -f2 | sort | grep ^// | wc
549 1098 14823
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.h: | cut -d: -f2 | sort | grep ^/\* | wc
7981 15962 215364
So a majority seems to go with the "more Linux C file style" /* as comment
marker... which is why I chose that...
/D
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-03 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 13:46 [PATCH] Add SPDX idenitifier and clarify license Thomas Hellstrom
2018-05-02 14:00 ` Christian König
2018-05-02 14:41 ` Thomas Hellstrom
2018-05-02 14:56 ` Dirk Hohndel
2018-05-14 16:00 ` Alex Deucher
2018-05-14 16:06 ` Christian König
2018-05-02 20:12 ` Sean Paul
2018-05-02 20:33 ` Sean Paul
2018-05-02 21:25 ` Dirk Hohndel
2018-05-03 12:46 ` Sean Paul
2018-05-03 15:41 ` Dirk Hohndel
2018-05-08 21:52 ` Alex Deucher
2018-05-08 23:11 ` Dirk Hohndel
2018-05-09 5:25 ` Thomas Hellstrom
2018-05-04 14:36 ` Christian König
2018-05-03 13:03 ` Fabio Estevam
2018-05-03 13:12 ` Christian König
2018-05-03 15:48 ` Dirk Hohndel [this message]
2018-05-03 15:53 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503154843.GG1309@rrmbpvm.gr8dns.org \
--to=dirk@hohndel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.