From: kbuild test robot <lkp@intel.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-block@vger.kernel.org,
cgroups@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Balbir Singh <bsingharora@gmail.com>,
Mike Galbraith <efault@gmx.de>, Oliver Yang <yangoliver@me.com>,
Shakeel Butt <shakeelb@google.com>, xxx xxx <x.qendo@gmail.com>,
Taras Kondratiuk <takondra@cisco.com>,
Daniel Walker <danielwa@cisco.com>,
Vinayak Menon <vinmenon@codeaurora.org>,
Ruslan Ruslichenko <rruslich@cisco.com>,
kernel-team@fb.com
Subject: Re: [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO
Date: Tue, 8 May 2018 11:04:09 +0800 [thread overview]
Message-ID: <201805080952.2yQWmzU2%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180507210135.1823-7-hannes@cmpxchg.org>
[-- Attachment #1: Type: text/plain, Size: 3398 bytes --]
Hi Johannes,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc4]
[cannot apply to next-20180507]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Johannes-Weiner/mm-workingset-don-t-drop-refault-information-prematurely/20180508-081214
config: x86_64-randconfig-x012-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from kernel/livepatch/../sched/sched.h:1317:0,
from kernel/livepatch/transition.c:27:
>> kernel/livepatch/../sched/stats.h:126:1: error: expected identifier or '(' before '{' token
{
^
vim +126 kernel/livepatch/../sched/stats.h
57
58 #ifdef CONFIG_PSI
59 /*
60 * PSI tracks state that persists across sleeps, such as iowaits and
61 * memory stalls. As a result, it has to distinguish between sleeps,
62 * where a task's runnable state changes, and requeues, where a task
63 * and its state are being moved between CPUs and runqueues.
64 */
65 static inline void psi_enqueue(struct task_struct *p, u64 now)
66 {
67 int clear = 0, set = TSK_RUNNING;
68
69 if (p->state == TASK_RUNNING || p->sched_psi_wake_requeue) {
70 if (p->flags & PF_MEMSTALL)
71 set |= TSK_MEMSTALL;
72 p->sched_psi_wake_requeue = 0;
73 } else {
74 if (p->in_iowait)
75 clear |= TSK_IOWAIT;
76 }
77
78 psi_task_change(p, now, clear, set);
79 }
80 static inline void psi_dequeue(struct task_struct *p, u64 now)
81 {
82 int clear = TSK_RUNNING, set = 0;
83
84 if (p->state == TASK_RUNNING) {
85 if (p->flags & PF_MEMSTALL)
86 clear |= TSK_MEMSTALL;
87 } else {
88 if (p->in_iowait)
89 set |= TSK_IOWAIT;
90 }
91
92 psi_task_change(p, now, clear, set);
93 }
94 static inline void psi_ttwu_dequeue(struct task_struct *p)
95 {
96 /*
97 * Is the task being migrated during a wakeup? Make sure to
98 * deregister its sleep-persistent psi states from the old
99 * queue, and let psi_enqueue() know it has to requeue.
100 */
101 if (unlikely(p->in_iowait || (p->flags & PF_MEMSTALL))) {
102 struct rq_flags rf;
103 struct rq *rq;
104 int clear = 0;
105
106 if (p->in_iowait)
107 clear |= TSK_IOWAIT;
108 if (p->flags & PF_MEMSTALL)
109 clear |= TSK_MEMSTALL;
110
111 rq = __task_rq_lock(p, &rf);
112 update_rq_clock(rq);
113 psi_task_change(p, rq_clock(rq), clear, 0);
114 p->sched_psi_wake_requeue = 1;
115 __task_rq_unlock(rq, &rf);
116 }
117 }
118 #else /* CONFIG_PSI */
119 static inline void psi_enqueue(struct task_struct *p, u64 now)
120 {
121 }
122 static inline void psi_dequeue(struct task_struct *p, u64 now)
123 {
124 }
125 static inline void psi_ttwu_dequeue(struct task_struct *p) {}
> 126 {
127 }
128 #endif /* CONFIG_PSI */
129
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28065 bytes --]
next prev parent reply other threads:[~2018-05-08 3:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 21:01 [PATCH 0/7] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-05-07 21:01 ` [PATCH 1/7] mm: workingset: don't drop refault information prematurely Johannes Weiner
2018-05-07 21:01 ` [PATCH 2/7] mm: workingset: tell cache transitions from workingset thrashing Johannes Weiner
2018-05-07 21:01 ` [PATCH 3/7] delayacct: track delays from thrashing cache pages Johannes Weiner
2018-05-07 21:01 ` [PATCH 4/7] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD Johannes Weiner
2018-05-07 21:01 ` [PATCH 5/7] sched: loadavg: make calc_load_n() public Johannes Weiner
2018-05-09 9:49 ` Peter Zijlstra
2018-05-10 13:46 ` Johannes Weiner
2018-05-07 21:01 ` [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-05-08 0:42 ` Randy Dunlap
2018-05-08 14:06 ` Johannes Weiner
2018-05-08 1:35 ` kbuild test robot
2018-05-08 3:04 ` kbuild test robot [this message]
2018-05-08 14:05 ` Johannes Weiner
2018-05-09 9:59 ` Peter Zijlstra
2018-05-10 13:49 ` Johannes Weiner
2018-05-09 10:04 ` Peter Zijlstra
2018-05-10 14:10 ` Johannes Weiner
2018-05-09 10:05 ` Peter Zijlstra
2018-05-10 14:13 ` Johannes Weiner
2018-05-09 10:14 ` Peter Zijlstra
2018-05-10 14:18 ` Johannes Weiner
2018-05-09 10:21 ` Peter Zijlstra
2018-05-10 14:24 ` Johannes Weiner
2018-05-09 10:26 ` Peter Zijlstra
2018-05-09 10:46 ` Peter Zijlstra
2018-05-09 11:38 ` Peter Zijlstra
2018-05-10 13:41 ` Johannes Weiner
2018-05-14 8:33 ` Peter Zijlstra
2018-05-09 10:55 ` Peter Zijlstra
2018-05-09 11:03 ` Vinayak Menon
2018-05-23 13:17 ` Johannes Weiner
2018-05-23 13:19 ` Vinayak Menon
2018-06-07 0:46 ` Suren Baghdasaryan
2018-05-07 21:01 ` [PATCH 7/7] psi: cgroup support Johannes Weiner
2018-05-09 11:07 ` Peter Zijlstra
2018-05-10 14:49 ` Johannes Weiner
2018-05-10 14:49 ` Johannes Weiner
2018-05-14 15:39 ` [PATCH 0/7] psi: pressure stall information for CPU, memory, and IO Christopher Lameter
2018-05-14 17:35 ` Bart Van Assche
2018-05-14 18:55 ` Johannes Weiner
2018-05-14 20:15 ` Christopher Lameter
2018-05-26 0:29 ` Suren Baghdasaryan
2018-05-29 18:16 ` Johannes Weiner
2018-05-30 23:32 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805080952.2yQWmzU2%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akpm@linuxfoundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=danielwa@cisco.com \
--cc=efault@gmx.de \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rruslich@cisco.com \
--cc=shakeelb@google.com \
--cc=takondra@cisco.com \
--cc=tj@kernel.org \
--cc=vinmenon@codeaurora.org \
--cc=x.qendo@gmail.com \
--cc=yangoliver@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.