Re: [PATCH v2] mm: Change return type to vm_fault_t

From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, hughd@google.com,
	dan.j.williams@intel.com, rientjes@google.com,
	mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
	aneesh.kumar@linux.vnet.ibm.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: Change return type to vm_fault_t
Date: Fri, 11 May 2018 11:15:46 -0700	[thread overview]
Message-ID: <20180511181546.GA25613@bombadil.infradead.org> (raw)
In-Reply-To: <20180511180639.GA1792@jordon-HP-15-Notebook-PC>

On Fri, May 11, 2018 at 11:36:39PM +0530, Souptick Joarder wrote:
>  mm/hugetlb.c | 2 +-
>  mm/mmap.c    | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Don't we also need to convert include/linux/mm_types.h:

@@ -621,7 +621,7 @@ struct vm_special_mapping {
         * If non-NULL, then this is called to resolve page faults
         * on the special mapping.  If used, .pages is not checked.
         */
-       int (*fault)(const struct vm_special_mapping *sm,
+       vm_fault_t (*fault)(const struct vm_special_mapping *sm,
                     struct vm_area_struct *vma,
                     struct vm_fault *vmf);
 
or are you leaving that for a later patch?
