From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH RFC net-next 5/7] selftests: fib_tests: Add option to pause after each test Date: Mon, 14 May 2018 19:51:10 -0700 Message-ID: <20180515025112.16647-6-dsahern@gmail.com> References: <20180515025112.16647-1-dsahern@gmail.com> Cc: Thomas.Winter@alliedtelesis.co.nz, idosch@mellanox.com, sharpd@cumulusnetworks.com, roopa@cumulusnetworks.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:40767 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbeEOCva (ORCPT ); Mon, 14 May 2018 22:51:30 -0400 Received: by mail-pl0-f65.google.com with SMTP id t12-v6so8504447plo.7 for ; Mon, 14 May 2018 19:51:30 -0700 (PDT) In-Reply-To: <20180515025112.16647-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Add option to pause after each test before cleanup is done. Allows user to do manual inspection or more ad-hoc testing after each test with the setup in tact. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh index 8c99f0689efc..12b648826151 100755 --- a/tools/testing/selftests/net/fib_tests.sh +++ b/tools/testing/selftests/net/fib_tests.sh @@ -9,6 +9,7 @@ ret=0 TESTS="unregister down carrier nexthop" VERBOSE=0 PAUSE_ON_FAIL=no +PAUSE=no IP="ip -netns testns" log_test() @@ -31,6 +32,13 @@ log_test() [ "$a" = "q" ] && exit 1 fi fi + + if [ "${PAUSE}" = "yes" ]; then + echo + echo "hit enter to continue, 'q' to quit" + read a + [ "$a" = "q" ] && exit 1 + fi } setup() @@ -576,6 +584,7 @@ usage: ${0##*/} OPTS -t Test(s) to run (default: all) (options: $TESTS) -p Pause on fail + -P Pause after each test before cleanup -v verbose mode (show commands and output) EOF } @@ -588,6 +597,7 @@ do case $o in t) TESTS=$OPTARG;; p) PAUSE_ON_FAIL=yes;; + P) PAUSE=yes;; v) VERBOSE=$(($VERBOSE + 1));; h) usage; exit 0;; *) usage; exit 1;; @@ -596,6 +606,9 @@ done PEER_CMD="ip netns exec ${PEER_NS}" +# make sure we don't pause twice +[ "${PAUSE}" = "yes" ] && PAUSE_ON_FAIL=no + if [ "$(id -u)" -ne 0 ];then echo "SKIP: Need root privileges" exit 0 -- 2.11.0