From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:46166 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbeEPLSy (ORCPT ); Wed, 16 May 2018 07:18:54 -0400 Date: Wed, 16 May 2018 04:18:51 -0700 From: Matthew Wilcox To: Christoph Hellwig Cc: Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, lustre-devel@lists.lustre.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 01/14] orangefs: don't return errno values from ->fault Message-ID: <20180516111851.GA20670@bombadil.infradead.org> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180516054348.15950-2-hch@lst.de> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, May 16, 2018 at 07:43:35AM +0200, Christoph Hellwig wrote: > + rc = orangefs_inode_getattr(file->f_mapping->host, 0, 1, STATX_SIZE); > if (rc) { > gossip_err("%s: orangefs_inode_getattr failed, " > "rc:%d:.\n", __func__, rc); > - return rc; > + return VM_FAULT_SIGBUS; Nope. orangefs_inode_getattr can return -ENOMEM. > } > return filemap_fault(vmf); > } > -- > 2.17.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Wed, 16 May 2018 04:18:51 -0700 Subject: [lustre-devel] [PATCH 01/14] orangefs: don't return errno values from ->fault In-Reply-To: <20180516054348.15950-2-hch@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-2-hch@lst.de> Message-ID: <20180516111851.GA20670@bombadil.infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, lustre-devel@lists.lustre.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org On Wed, May 16, 2018 at 07:43:35AM +0200, Christoph Hellwig wrote: > + rc = orangefs_inode_getattr(file->f_mapping->host, 0, 1, STATX_SIZE); > if (rc) { > gossip_err("%s: orangefs_inode_getattr failed, " > "rc:%d:.\n", __func__, rc); > - return rc; > + return VM_FAULT_SIGBUS; Nope. orangefs_inode_getattr can return -ENOMEM. > } > return filemap_fault(vmf); > } > -- > 2.17.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: willy@infradead.org (Matthew Wilcox) Date: Wed, 16 May 2018 04:18:51 -0700 Subject: [PATCH 01/14] orangefs: don't return errno values from ->fault In-Reply-To: <20180516054348.15950-2-hch@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-2-hch@lst.de> Message-ID: <20180516111851.GA20670@bombadil.infradead.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 16, 2018 at 07:43:35AM +0200, Christoph Hellwig wrote: > + rc = orangefs_inode_getattr(file->f_mapping->host, 0, 1, STATX_SIZE); > if (rc) { > gossip_err("%s: orangefs_inode_getattr failed, " > "rc:%d:.\n", __func__, rc); > - return rc; > + return VM_FAULT_SIGBUS; Nope. orangefs_inode_getattr can return -ENOMEM. > } > return filemap_fault(vmf); > } > -- > 2.17.0 >