All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Schmaus <flo@geekplace.eu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Florian Schmaus <flo@geekplace.eu>, linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] return EINVAL error instead of BUG_ON()
Date: Wed, 16 May 2018 18:08:13 +0200	[thread overview]
Message-ID: <20180516160816.20251-1-flo@geekplace.eu> (raw)
In-Reply-To: <20180516120527.29403-1-flo@geekplace.eu>

This patch series makes driver_register() emit an error message and
return a failure code instead of triggering a BUG_ON().

The first patch will cause driver_register() to fail gracefully if the
driver's bus was not initialized while printing out the name of the
faulty driver *and* the name of the involved bus. The second patch
records the error code if bus_register() fails. The third and final
patch of the series extends the first patch so that the recorded error
code is also print out if non-zero. Otherwhise, if drv->bus->p is NULL
but the error code is zero, then probably bus_register() was never
called before.

Florian Schmaus (3):
  driver-core: return EINVAL error instead of BUG_ON()
  driver-core: record error on bus registration
  driver-core: print bus registration error value

 drivers/base/bus.c     |  6 +++++-
 drivers/base/driver.c  | 12 +++++++++++-
 include/linux/device.h |  1 +
 3 files changed, 17 insertions(+), 2 deletions(-)

-- 
2.16.1

  reply	other threads:[~2018-05-16 16:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  9:49 [PATCH] driver-core: Log the BUG() causing driver Florian Schmaus
2018-03-07 15:13 ` Greg Kroah-Hartman
2018-03-07 15:36   ` Florian Schmaus
2018-05-04 13:23 ` [PATCH v2] driver-core: Return EBUSY error instead of BUG_ON() Florian Schmaus
2018-05-04 17:37   ` Greg Kroah-Hartman
2018-05-04 17:38   ` Greg Kroah-Hartman
2018-05-15 13:51   ` [PATCH v3 0/3] return EINVAL " Florian Schmaus
2018-05-16 12:05     ` [PATCH v4 " Florian Schmaus
2018-05-16 16:08       ` Florian Schmaus [this message]
2018-05-23 15:59         ` [PATCH v6 0/3] driver-core: " Florian Schmaus
2018-05-25 16:21           ` Greg Kroah-Hartman
2018-05-23 15:59         ` [PATCH v6 1/3] " Florian Schmaus
2018-05-23 15:59         ` [PATCH v6 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-23 15:59         ` [PATCH v6 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 16:08       ` [PATCH v5 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-16 16:35         ` Greg Kroah-Hartman
2018-05-16 16:08       ` [PATCH v5 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-16 16:35         ` Greg Kroah-Hartman
2018-05-16 16:08       ` [PATCH v5 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 16:37         ` Greg Kroah-Hartman
2018-05-16 12:05     ` [PATCH v4 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-16 15:39       ` Greg Kroah-Hartman
2018-05-16 16:07         ` Florian Schmaus
2018-05-16 12:05     ` [PATCH v4 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-17 13:08       ` kbuild test robot
2018-05-16 12:05     ` [PATCH v4 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 12:09       ` Florian Schmaus
2018-05-16 15:38         ` Greg Kroah-Hartman
2018-05-16 15:37       ` Greg Kroah-Hartman
2018-05-17  8:10       ` kbuild test robot
2018-05-15 13:51   ` [PATCH v3 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-15 15:10     ` Greg Kroah-Hartman
2018-05-15 15:13       ` Greg Kroah-Hartman
2018-05-15 13:51   ` [PATCH v3 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-16  8:50     ` kbuild test robot
2018-05-15 13:51   ` [PATCH v3 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-15 15:12     ` Greg Kroah-Hartman
2018-05-16  8:24     ` kbuild test robot
2018-05-16  8:35     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516160816.20251-1-flo@geekplace.eu \
    --to=flo@geekplace.eu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.