From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:48802 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbeEPRaR (ORCPT ); Wed, 16 May 2018 13:30:17 -0400 Date: Wed, 16 May 2018 19:34:45 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Souptick Joarder , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, lustre-devel@lists.lustre.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking Message-ID: <20180516173445.GA6088@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516150829.GA4904@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180516150829.GA4904@magnolia> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, May 16, 2018 at 08:08:29AM -0700, Darrick J. Wong wrote: > Uh, we're changing function signatures /and/ redefinining vm_fault_t? > All in the same 90K patch? > > I /was/ expecting a series of "convert XXXXX and all callers/users" > patches followed by a trivial one to switch the definition, not a giant > pile of change. FWIW I don't mind so much if you make a patch > containing a change for some super-common primitive and a hojillion > little diff hunks tree-wide, but only one logical change at a time for a > big patch, please... > > I quite prefer seeing the whole series from start to finish all packaged > up in one series, but wow this was overwhelming. :/ Another vote to split the change of the typedef, ok I get the message.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking Date: Wed, 16 May 2018 19:34:45 +0200 Message-ID: <20180516173445.GA6088@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516150829.GA4904@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180516150829.GA4904@magnolia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Archive: List-Post: To: "Darrick J. Wong" Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org List-ID: T24gV2VkLCBNYXkgMTYsIDIwMTggYXQgMDg6MDg6MjlBTSAtMDcwMCwgRGFycmljayBKLiBXb25n IHdyb3RlOgo+IFVoLCB3ZSdyZSBjaGFuZ2luZyBmdW5jdGlvbiBzaWduYXR1cmVzIC9hbmQvIHJl ZGVmaW5pbmluZyB2bV9mYXVsdF90Pwo+IEFsbCBpbiB0aGUgc2FtZSA5MEsgcGF0Y2g/Cj4gCj4g SSAvd2FzLyBleHBlY3RpbmcgYSBzZXJpZXMgb2YgImNvbnZlcnQgWFhYWFggYW5kIGFsbCBjYWxs ZXJzL3VzZXJzIgo+IHBhdGNoZXMgZm9sbG93ZWQgYnkgYSB0cml2aWFsIG9uZSB0byBzd2l0Y2gg dGhlIGRlZmluaXRpb24sIG5vdCBhIGdpYW50Cj4gcGlsZSBvZiBjaGFuZ2UuICBGV0lXIEkgZG9u J3QgbWluZCBzbyBtdWNoIGlmIHlvdSBtYWtlIGEgcGF0Y2gKPiBjb250YWluaW5nIGEgY2hhbmdl IGZvciBzb21lIHN1cGVyLWNvbW1vbiBwcmltaXRpdmUgYW5kIGEgaG9qaWxsaW9uCj4gbGl0dGxl IGRpZmYgaHVua3MgdHJlZS13aWRlLCBidXQgb25seSBvbmUgbG9naWNhbCBjaGFuZ2UgYXQgYSB0 aW1lIGZvciBhCj4gYmlnIHBhdGNoLCBwbGVhc2UuLi4KPiAKPiBJIHF1aXRlIHByZWZlciBzZWVp bmcgdGhlIHdob2xlIHNlcmllcyBmcm9tIHN0YXJ0IHRvIGZpbmlzaCBhbGwgcGFja2FnZWQKPiB1 cCBpbiBvbmUgc2VyaWVzLCBidXQgd293IHRoaXMgd2FzIG92ZXJ3aGVsbWluZy4gOi8KCkFub3Ro ZXIgdm90ZSB0byBzcGxpdCB0aGUgY2hhbmdlIG9mIHRoZSB0eXBlZGVmLCBvayBJIGdldCB0aGUg bWVzc2FnZS4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 16 May 2018 19:34:45 +0200 Subject: [Ocfs2-devel] [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516150829.GA4904@magnolia> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516150829.GA4904@magnolia> Message-ID: <20180516173445.GA6088@lst.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Darrick J. Wong" Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org On Wed, May 16, 2018 at 08:08:29AM -0700, Darrick J. Wong wrote: > Uh, we're changing function signatures /and/ redefinining vm_fault_t? > All in the same 90K patch? > > I /was/ expecting a series of "convert XXXXX and all callers/users" > patches followed by a trivial one to switch the definition, not a giant > pile of change. FWIW I don't mind so much if you make a patch > containing a change for some super-common primitive and a hojillion > little diff hunks tree-wide, but only one logical change at a time for a > big patch, please... > > I quite prefer seeing the whole series from start to finish all packaged > up in one series, but wow this was overwhelming. :/ Another vote to split the change of the typedef, ok I get the message.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 16 May 2018 19:34:45 +0200 Subject: [lustre-devel] [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516150829.GA4904@magnolia> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516150829.GA4904@magnolia> Message-ID: <20180516173445.GA6088@lst.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Darrick J. Wong" Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org On Wed, May 16, 2018 at 08:08:29AM -0700, Darrick J. Wong wrote: > Uh, we're changing function signatures /and/ redefinining vm_fault_t? > All in the same 90K patch? > > I /was/ expecting a series of "convert XXXXX and all callers/users" > patches followed by a trivial one to switch the definition, not a giant > pile of change. FWIW I don't mind so much if you make a patch > containing a change for some super-common primitive and a hojillion > little diff hunks tree-wide, but only one logical change at a time for a > big patch, please... > > I quite prefer seeing the whole series from start to finish all packaged > up in one series, but wow this was overwhelming. :/ Another vote to split the change of the typedef, ok I get the message.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 16 May 2018 19:34:45 +0200 Subject: [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516150829.GA4904@magnolia> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516150829.GA4904@magnolia> Message-ID: <20180516173445.GA6088@lst.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 16, 2018 at 08:08:29AM -0700, Darrick J. Wong wrote: > Uh, we're changing function signatures /and/ redefinining vm_fault_t? > All in the same 90K patch? > > I /was/ expecting a series of "convert XXXXX and all callers/users" > patches followed by a trivial one to switch the definition, not a giant > pile of change. FWIW I don't mind so much if you make a patch > containing a change for some super-common primitive and a hojillion > little diff hunks tree-wide, but only one logical change at a time for a > big patch, please... > > I quite prefer seeing the whole series from start to finish all packaged > up in one series, but wow this was overwhelming. :/ Another vote to split the change of the typedef, ok I get the message..