From: David Sterba <dsterba@suse.cz>
To: Su Yue <suy.fnst@cn.fujitsu.com>
Cc: Liu Bo <bo.liu@linux.alibaba.com>,
linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v2 0/6] btrfs_search_slot cleanups
Date: Tue, 22 May 2018 14:02:14 +0200 [thread overview]
Message-ID: <20180522120214.GG6649@twin.jikos.cz> (raw)
In-Reply-To: <9b80bec0-b7cf-10da-f379-373fe6ec776a@cn.fujitsu.com>
On Tue, May 22, 2018 at 07:05:14PM +0800, Su Yue wrote:
> Hi Liu and David,
> During my local xfstests on kdave/for-next, btrfs/139 failed and
> btrfs BUG_ON due to qgroup rescan.
> The bisect result is commit 560215eb3f32("Merge branch
> 'ext/liubo/search-cleanups-wip' into for-next-next-v4.18-20180521")
> which seems merged this patchset.
> The dmesg file is attached.
>
> On 05/18/2018 11:00 AM, Liu Bo wrote:
> > Here are a collection of patches I did for btrfs_search_slot().
> >
> > v2: more explicit commit log for each patch.
> >
> > Liu Bo (6):
> > Btrfs: remove superfluous free_extent_buffer
> > Btrfs: use more straightforward extent_buffer_uptodate
> > Btrfs: move get root of btrfs_search_slot to a helper
> > Btrfs: remove unused check of skip_locking
> > Btrfs: grab write lock directly if write_lock_level is the max level
> > Btrfs: remove always true check in unlock_up
> >
> > fs/btrfs/ctree.c | 121 +++++++++++++++++++++++++++++++++----------------------
> > 1 file changed, 73 insertions(+), 48 deletions(-)
> >
>
>
> [ 46.129166] BTRFS info (device vdb): disk space caching is enabled
> [ 46.130545] BTRFS info (device vdb): has skinny extents
> [ 46.171386] mount (2798) used greatest stack depth: 12920 bytes left
> [ 46.508170] BTRFS: device fsid 83a117c7-a9ea-4bf5-b42f-7092078610d5 devid 1 transid 5 /dev/vdc
> [ 46.562428] BTRFS info (device vdc): disk space caching is enabled
> [ 46.563690] BTRFS info (device vdc): has skinny extents
> [ 46.564563] BTRFS info (device vdc): flagging fs with big metadata feature
> [ 46.587441] BTRFS info (device vdc): checking UUID tree
> [ 46.766765] BTRFS info (device vdb): disk space caching is enabled
> [ 46.768197] BTRFS info (device vdb): has skinny extents
> [ 46.875534] run fstests btrfs/139 at 2018-05-22 18:40:36
> [ 47.559411] BTRFS: device fsid 065f3825-057e-451f-8722-0d94d4a3f36f devid 1 transid 5 /dev/vdc
> [ 47.612001] BTRFS info (device vdc): disk space caching is enabled
> [ 47.613254] BTRFS info (device vdc): has skinny extents
> [ 47.614147] BTRFS info (device vdc): flagging fs with big metadata feature
> [ 47.632377] BTRFS info (device vdc): checking UUID tree
> [ 47.681656] btrfs (3176) used greatest stack depth: 12632 bytes left
> [ 47.691156] ------------[ cut here ]------------
> [ 47.692084] kernel BUG at fs/btrfs/locking.c:286!
I saw the crash too but did not investigate the root cause. So I'll
remove the branch from for-next until it's fixed. Thanks for the report.
next prev parent reply other threads:[~2018-05-22 12:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 3:00 [PATCH v2 0/6] btrfs_search_slot cleanups Liu Bo
2018-05-18 3:00 ` [PATCH v2 1/6] Btrfs: remove superfluous free_extent_buffer Liu Bo
2018-05-18 5:15 ` Qu Wenruo
2018-05-18 3:00 ` [PATCH v2 2/6] Btrfs: use more straightforward extent_buffer_uptodate Liu Bo
2018-05-18 5:17 ` Qu Wenruo
2018-05-18 16:00 ` David Sterba
2018-05-18 3:00 ` [PATCH v2 3/6] Btrfs: move get root of btrfs_search_slot to a helper Liu Bo
2018-05-18 5:20 ` Qu Wenruo
2018-05-18 3:00 ` [PATCH v2 4/6] Btrfs: remove unused check of skip_locking Liu Bo
2018-05-18 5:27 ` Qu Wenruo
2018-05-28 14:21 ` David Sterba
2018-05-28 15:33 ` Nikolay Borisov
2018-05-29 13:27 ` [PATCH v3] " Liu Bo
2018-05-29 14:49 ` David Sterba
2018-05-18 3:00 ` [PATCH v2 5/6] Btrfs: grab write lock directly if write_lock_level is the max level Liu Bo
2018-05-28 14:32 ` David Sterba
2018-05-18 3:00 ` [PATCH v2 6/6] Btrfs: remove always true check in unlock_up Liu Bo
2018-05-18 5:31 ` Qu Wenruo
2018-05-22 11:05 ` [PATCH v2 0/6] btrfs_search_slot cleanups Su Yue
2018-05-22 12:02 ` David Sterba [this message]
2018-05-22 12:35 ` Nikolay Borisov
2018-05-23 2:16 ` Su Yue
2018-05-23 12:34 ` David Sterba
2018-05-23 14:11 ` Liu Bo
2018-05-28 14:40 ` David Sterba
2018-05-28 16:17 ` David Sterba
2018-05-29 8:27 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522120214.GG6649@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=suy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.