All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*
Date: Fri, 15 Jun 2018 14:31:53 +0200	[thread overview]
Message-ID: <20180615143153.21bfd105@redhat.com> (raw)
In-Reply-To: <bbac3756-1966-b69b-8974-d6c9b31208eb@redhat.com>

On Fri, 15 Jun 2018 13:52:25 +0200
David Hildenbrand <david@redhat.com> wrote:

> On 15.06.2018 13:51, Igor Mammedov wrote:
> > On Fri, 15 Jun 2018 13:24:50 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >   
> >> Use a similar naming scheme as spapr. This way, we can go ahead and
> >> rename e.g. pc_dimm_memory_plug to pc_dimm_plug_plug, which avoids  
> >                                      ^^^^^ typo?  
> 
> Indeed, luckily only in the patch description.

with that fixed
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

  reply	other threads:[~2018-06-15 12:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 11:24 [Qemu-devel] [PATCH v2 00/12] pc-dimm: next bunch of cleanups David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity" David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* David Hildenbrand
2018-06-15 11:51   ` Igor Mammedov
2018-06-15 11:52     ` David Hildenbrand
2018-06-15 12:31       ` Igor Mammedov [this message]
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_* David Hildenbrand
2018-06-15 12:33   ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header David Hildenbrand
2018-06-15 12:36   ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug() David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory() David Hildenbrand
2018-06-15 12:39   ` Igor Mammedov
2018-06-15 12:45     ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 07/12] pc-dimm: merge get_(vmstate_)memory_region() David Hildenbrand
2018-06-15 12:45   ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region() David Hildenbrand
2018-06-15 12:46   ` Igor Mammedov
2018-06-15 12:50     ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 09/12] nvdimm: convert "unarmed" into a static property David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 10/12] nvdimm: convert "label-size" " David Hildenbrand
2018-06-15 12:53   ` Igor Mammedov
2018-06-15 13:30     ` David Hildenbrand
2018-06-15 13:40       ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 11/12] nvdimm: make get_memory_region() perform checks and initialization David Hildenbrand
2018-06-15 13:14   ` Igor Mammedov
2018-06-15 11:25 ` [Qemu-devel] [PATCH v2 12/12] pc-dimm: get_memory_region() will not fail after realize David Hildenbrand
2018-06-15 13:19   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615143153.21bfd105@redhat.com \
    --to=imammedo@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.