From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Jun 2018 15:02:24 -0700 From: Matthias Kaehlcke To: Balakrishna Godavarthi Cc: marcel@holtmann.org, johan.hedberg@gmail.com, robh@kernel.org, thierry.escande@linaro.org, linux-bluetooth@vger.kernel.org, rtatiya@codeaurora.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v7 7/8] Bluetooth: btqca: Add wcn3990 firmware download support. Message-ID: <20180618220224.GV88063@google.com> References: <20180616062718.29844-1-bgodavar@codeaurora.org> <20180616062718.29844-8-bgodavar@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20180616062718.29844-8-bgodavar@codeaurora.org> List-ID: On Sat, Jun 16, 2018 at 11:57:17AM +0530, Balakrishna Godavarthi wrote: > This patch enables the RAM and NV patch download for wcn3990. > > Signed-off-by: Balakrishna Godavarthi > --- > Changes in v7: > * used redefined function qca_uart_setup for firmware download. > > Changes in v6: > * add code to derive the firmware files based on ROM Version. > * created new patch for common function of ROME and wcn3990. > > Changes in v5: > * moved changes related to hci_qca. > * addressed review comments. > > Changes in v4: > * initial patch. > --- > drivers/bluetooth/btqca.c | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index f748730039cf..f0a4205068b8 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -332,6 +332,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, uint8_t soc_type, > { > struct rome_config config; > int err; > + u8 rom_ver; > > bt_dev_dbg(hdev, "QCA setup on UART"); > > @@ -346,11 +347,21 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, uint8_t soc_type, > } > bt_dev_info(hdev, "QCA controller version 0x%08x", soc_ver); > } > - > /* Download rampatch file */ > config.type = TLV_TYPE_PATCH; > - snprintf(config.fwname, sizeof(config.fwname), "qca/rampatch_%08x.bin", > - soc_ver); > + if (soc_type == QCA_WCN3990) { > + /* Firmware files to download are based on ROM version. > + * ROM version is derived from last two bytes of soc_ver. > + */ nit: new line after '/*' (https://www.kernel.org/doc/html/v4.17/process/coding-style.html#commenting)) Reviewed-by: Matthias Kaehlcke