From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: transactionless xfs_bunmapi shouldn't do format conversion
Date: Thu, 21 Jun 2018 15:55:08 -0700 [thread overview]
Message-ID: <20180621225508.GL4838@magnolia> (raw)
In-Reply-To: <20180621223406.GV19934@dastard>
On Fri, Jun 22, 2018 at 08:34:06AM +1000, Dave Chinner wrote:
> On Wed, Jun 20, 2018 at 12:31:42AM -0700, Christoph Hellwig wrote:
> > On Mon, Jun 18, 2018 at 09:54:05PM -0700, Darrick J. Wong wrote:
> > > ...it's also weird that xfs_bmap_punch_delalloc_range calls xfs_bunmapi
> > > with no transaction and a xfs_defer that we dump on the ground.
> > >
> > > So yes, I think the patch does fix the crash, but it's kinda gross.
> > >
> > > Thoughts?
> >
> > I've got an alternative solution:
> >
> > http://git.infradead.org/users/hch/xfs.git/commitdiff/a1c0685b2085b448cbe02f0f9ff0c8771e3f4496
> >
> > The only bit that is missing is removing the now unused support for
> > a NULL tp in __xfs_bunmapi..
>
> Ah, I forgot about that patch. Thanks for the reminder, Christoph!
>
> Darrick, can we get Christoph's patch in as a standalone bug fix
> rather than wait for the bufferhead removal to be merged?
Ok, will do. AFAICT if I merge that patch then I can drop this one,
right?
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-21 22:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 2:41 [PATCH 0/2] xfs: handle inode extent count mismatch Dave Chinner
2018-06-19 2:41 ` [PATCH 1/2] xfs: transactionless xfs_bunmapi shouldn't do format conversion Dave Chinner
2018-06-19 4:54 ` Darrick J. Wong
2018-06-19 5:27 ` Dave Chinner
2018-06-19 6:06 ` Darrick J. Wong
2018-06-19 23:33 ` Dave Chinner
2018-06-21 16:42 ` Darrick J. Wong
2018-06-20 7:31 ` Christoph Hellwig
2018-06-21 22:34 ` Dave Chinner
2018-06-21 22:55 ` Darrick J. Wong [this message]
2018-06-21 23:23 ` Dave Chinner
2018-06-19 2:41 ` [PATCH 2/2] xfs: More robust inode extent count validation Dave Chinner
2018-06-19 4:57 ` Darrick J. Wong
2018-06-19 5:29 ` Dave Chinner
2018-06-19 6:07 ` Darrick J. Wong
2018-06-20 7:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621225508.GL4838@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.