From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/packet: fix use-after-free Date: Fri, 22 Jun 2018 07:18:28 +0900 (KST) Message-ID: <20180622.071828.1940755549930973800.davem@davemloft.net> References: <20180621211602.62011-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, willemb@google.com To: edumazet@google.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932753AbeFUWSb (ORCPT ); Thu, 21 Jun 2018 18:18:31 -0400 In-Reply-To: <20180621211602.62011-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Thu, 21 Jun 2018 14:16:02 -0700 > We should put copy_skb in receive_queue only after > a successful call to virtio_net_hdr_from_skb(). > > syzbot report : ... > Fixes: 58d19b19cd99 ("packet: vnet_hdr support for tpacket_rcv") > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Cc: Willem de Bruijn Applied and queued up for -stable, thanks Eric.