From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
marcelo.leitner@gmail.com, paulb@mellanox.com
Subject: Re: [PATCH net v2] cls_flower: fix use after free in flower S/W path
Date: Fri, 22 Jun 2018 07:25:05 +0900 (KST) [thread overview]
Message-ID: <20180622.072505.191579217918884711.davem@davemloft.net> (raw)
In-Reply-To: <fd96de4e9dc358e3982922ae681fdb1b9d8ae72a.1529603970.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Thu, 21 Jun 2018 20:02:16 +0200
> If flower filter is created without the skip_sw flag, fl_mask_put()
> can race with fl_classify() and we can destroy the mask rhashtable
> while a lookup operation is accessing it.
...
> Fix the above waiting for a RCU grace period before destroying the
> rhashtable: we need to use tcf_queue_work(), as rhashtable_destroy()
> must run in process context, as pointed out by Cong Wang.
>
> v1 -> v2: use tcf_queue_work to run rhashtable_destroy().
>
> Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2018-06-21 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:02 [PATCH net v2] cls_flower: fix use after free in flower S/W path Paolo Abeni
2018-06-21 18:16 ` Jiri Pirko
2018-06-21 22:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622.072505.191579217918884711.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.