From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWBlN-0004em-2B for qemu-devel@nongnu.org; Thu, 21 Jun 2018 22:25:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWBlM-0007fZ-62 for qemu-devel@nongnu.org; Thu, 21 Jun 2018 22:25:25 -0400 Date: Fri, 22 Jun 2018 10:25:12 +0800 From: Fam Zheng Message-ID: <20180622022512.GB5449@lemon.usersys.redhat.com> References: <20180621222143.27266-1-naravamudan@digitalocean.com> <20180621222143.27266-3-naravamudan@digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180621222143.27266-3-naravamudan@digitalocean.com> Subject: Re: [Qemu-devel] [PATCH v3 2/2] block/file-posix: reconfigure aio on iothread start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nishanth Aravamudan Cc: Eric Blake , Kevin Wolf , John Snow , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , qemu-block@nongnu.org, qemu-devel@nongnu.org On Thu, 06/21 15:21, Nishanth Aravamudan wrote: > When the AioContext changes, we need to associate a LinuxAioState with > the new AioContext. Use the bdrv_attach_aio_context callback and call > the new aio_setup_linux_aio(), which will allocate a new AioContext if > needed, and return errors on failures. If it fails for any reason, > fallback to threaded AIO with an error message, as the device is already > in-use by the guest. > > Signed-off-by: Nishanth Aravamudan > --- > Note this patch didn't exist in v2, but is a result of feedback to that > posting. This should be squashed into patch 1, no? Fam