From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [6/9] ALSA: usb: caiaq: use usb_fill_int_urb() From: Sebastian Andrzej Siewior Message-Id: <20180622101428.wcdnlexsbcvltqpu@linutronix.de> Date: Fri, 22 Jun 2018 12:14:29 +0200 To: Daniel Mack Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, tglx@linutronix.de, Takashi Iwai , Jaroslav Kysela List-ID: T24gMjAxOC0wNi0yMiAxMjowMToxMyBbKzAyMDBdLCBEYW5pZWwgTWFjayB3cm90ZToKPiBIbW0s IHRoZXJlIGlzIG5vIHN1Y2ggdGhpbmcgYXMgdXNiX2ZpbGxfaXNvX3VyYigpIGluIG15IHRyZWUs IGFyZSB5b3UgZ29pbmcKPiB0byBhZGQgdGhhdD8KClllcy4KCj4gVGhlIG9ubHkgcGFydCB0aGF0 IG5lZWRzIGF0dGVudGlvbiBpcyB0aGUgaW50ZXJ2YWwgcGFyYW1ldGVyLCB3aGljaCBpcwo+IHBh c3NlZCB0byB1c2JfZmlsbF9pbnRfdXJiKCkgYXMgMSBub3csIGFuZCBoZW5jZSB1cmItPmludGVy dmFsIHdpbGwgYWxzbyBiZQo+IDEsIGp1c3QgbGlrZSB0aGUgb3Blbi1jb2RlZCB2ZXJzaW9uIGJl Zm9yZS4gVW5sZXNzIEkgbWlzcyBhbnl0aGluZywgeW91cgo+IGNvbnZlcnNpb24gc2hvdWxkIHdv cmssIGJ1dCBJIGhhdmVuJ3QgdGVzdGVkIGl0IHlldC4KCkl0IHNob3VsZCB3b3JrIGluIG1vc3Qg Y2FzZXMuIFRoZSBwb2ludCBpcyB0aGF0IHRoZSBhcmd1bWVudCBleHBlY3RzCmJJbnRlcnZhbCAo ZnJvbSB0aGUgZW5kcG9pbnQpIHdoaWNoIGhhcyBhIGRpZmZlcmVudCBlbmNvZGluZyBvbiBGUyB2 cwpIUy9TUyBmb3IgSU5UUiBlbmRwb2ludHMgYnV0IG5vdCBmb3IgSVNPQyBlbmRwb2ludHMgYW5k IEkgZ290IHRoaXMgd3JvbmcKaW5pdGlhbGx5LgoKPiBCdXQgSSBhZ3JlZSB0aGUgZnVuY3Rpb24g bmFtZSBpcyBtaXNsZWFkaW5nLCBzbyB3ZSBzaG91bGQgcHJvYmFibHkgZ2V0IGEKPiB1c2JfZmls bF9pc29fdXJiKCkgYW5kIHVzZSBpdCB3aGVyZSBhcHByb3ByaWF0ZS4gQUZBSUNTLCBpdCB3aWxs IGJlCj4gaWRlbnRpY2FsIHRvIHVzYl9maWxsX2J1bGtfdXJiKCksIGFzIHRoZSBlbmRwb2ludCB0 eXBlIGlzIGVuY29kZWQgaW4gdGhlCj4gcGlwZS4gTWF5YmUgaXQncyB3b3J0aCBhZGRpbmcgYSBj aGVjaz8KCldoYXQgY2hlY2s/Cml0IHNob3VsZCBiZSBpZGVudGljYWwgdG8gSU5UUiB3aXRob3V0 IHRoZSBzcGVlZCBjaGVjayAoYWx3YXlzIHRoZSBIUwp2ZXJzaW9uIHNob3VsZCBiZSB1c2VkKS4g SSBuZWVkIHRvIGNoZWNrIGlmIGl0IG1ha2VzIHNlbnNlIHRvIGV4dGVuZCB0aGUKcGFyYW1ldGVy cyB0byBjb3ZlciAtPm51bWJlcl9vZl9wYWNrZXRzIGFuZCBzbyBvbi4KQW55IHdheSwgSSBwbGFu IHRvIGZpcnN0IFJGQyB0aGUgZnVuY3Rpb24sIGxhbmQgaXQgdXBzdHJlYW0gYW5kIHRoZW4KY29u dmVydCB0aGUgdXNlcnMuCgo+IFRoYW5rcywKPiBEYW5pZWwKClNlYmFzdGlhbgotLS0KVG8gdW5z dWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4 LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5v cmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRv bW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Date: Fri, 22 Jun 2018 12:14:29 +0200 Message-ID: <20180622101428.wcdnlexsbcvltqpu@linutronix.de> References: <20180619215521.13688-1-bigeasy@linutronix.de> <20180619215521.13688-7-bigeasy@linutronix.de> <2f8cbd9b-55ad-d543-d26a-c4452717b121@zonque.org> <20180621211639.a7vym5mikaejvlgw@linutronix.de> <156bfc42-650f-1ac0-73d5-085556ae318c@zonque.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from Galois.linutronix.de (galois.linutronix.de [146.0.238.70]) by alsa0.perex.cz (Postfix) with ESMTP id 7CDA92676DF for ; Fri, 22 Jun 2018 12:14:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <156bfc42-650f-1ac0-73d5-085556ae318c@zonque.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, tglx@linutronix.de, Takashi Iwai List-Id: alsa-devel@alsa-project.org On 2018-06-22 12:01:13 [+0200], Daniel Mack wrote: > Hmm, there is no such thing as usb_fill_iso_urb() in my tree, are you going > to add that? Yes. > The only part that needs attention is the interval parameter, which is > passed to usb_fill_int_urb() as 1 now, and hence urb->interval will also be > 1, just like the open-coded version before. Unless I miss anything, your > conversion should work, but I haven't tested it yet. It should work in most cases. The point is that the argument expects bInterval (from the endpoint) which has a different encoding on FS vs HS/SS for INTR endpoints but not for ISOC endpoints and I got this wrong initially. > But I agree the function name is misleading, so we should probably get a > usb_fill_iso_urb() and use it where appropriate. AFAICS, it will be > identical to usb_fill_bulk_urb(), as the endpoint type is encoded in the > pipe. Maybe it's worth adding a check? What check? it should be identical to INTR without the speed check (always the HS version should be used). I need to check if it makes sense to extend the parameters to cover ->number_of_packets and so on. Any way, I plan to first RFC the function, land it upstream and then convert the users. > Thanks, > Daniel Sebastian