From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1AA8C43143 for ; Fri, 22 Jun 2018 12:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 984F2241B1 for ; Fri, 22 Jun 2018 12:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 984F2241B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932944AbeFVMTl (ORCPT ); Fri, 22 Jun 2018 08:19:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:44492 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbeFVMTk (ORCPT ); Fri, 22 Jun 2018 08:19:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D4842ADD5; Fri, 22 Jun 2018 12:19:38 +0000 (UTC) Date: Fri, 22 Jun 2018 14:19:36 +0200 From: Michal Hocko To: =?utf-8?B?56a56Iif6ZSu?= Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu Subject: Re: [PATCH v9] Refactor part of the oom report in dump_header Message-ID: <20180622121936.GX10465@dhcp22.suse.cz> References: <1529056341-16182-1-git-send-email-ufo19890607@gmail.com> <20180622083949.GR10465@dhcp22.suse.cz> <20180622104217.GV10465@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 22-06-18 19:40:54, 禹舟键 wrote: > Hi Michal > > You misunderstood my suggestion. Let me be more specific. Please > > separate the whole new oom_constraint including its _usage_. > > Sorry for misunderstanding your words. I think you want me to separate > enum oom_constraint and static const char * const > oom_constraint_text[] to two parts, am I right ? Just split the patch into two parts. The first to add oom_constraint* and use it. And the second which adds the missing memcg information to the oom report. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id C2E3B6B0006 for ; Fri, 22 Jun 2018 08:19:41 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id f16-v6so445533edq.18 for ; Fri, 22 Jun 2018 05:19:41 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id r4-v6si3485840edo.320.2018.06.22.05.19.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 22 Jun 2018 05:19:39 -0700 (PDT) Date: Fri, 22 Jun 2018 14:19:36 +0200 From: Michal Hocko Subject: Re: [PATCH v9] Refactor part of the oom report in dump_header Message-ID: <20180622121936.GX10465@dhcp22.suse.cz> References: <1529056341-16182-1-git-send-email-ufo19890607@gmail.com> <20180622083949.GR10465@dhcp22.suse.cz> <20180622104217.GV10465@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: =?utf-8?B?56a56Iif6ZSu?= Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu On Fri 22-06-18 19:40:54, c|1e??e?(R) wrote: > Hi Michal > > You misunderstood my suggestion. Let me be more specific. Please > > separate the whole new oom_constraint including its _usage_. > > Sorry for misunderstanding your words. I think you want me to separate > enum oom_constraint and static const char * const > oom_constraint_text[] to two parts, am I right ? Just split the patch into two parts. The first to add oom_constraint* and use it. And the second which adds the missing memcg information to the oom report. -- Michal Hocko SUSE Labs