All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <naravamudan@digitalocean.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, Eric Blake <eblake@redhat.com>,
	John Snow <jsnow@redhat.com>, Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/2] block/file-posix: reconfigure aio on iothread start
Date: Fri, 22 Jun 2018 10:12:24 -0700	[thread overview]
Message-ID: <20180622171224.GB20261@breakout> (raw)
In-Reply-To: <20180622090206.GD4366@localhost.localdomain>

On 22.06.2018 [11:02:06 +0200], Kevin Wolf wrote:
> Am 22.06.2018 um 04:25 hat Fam Zheng geschrieben:
> > On Thu, 06/21 15:21, Nishanth Aravamudan wrote:
> > > When the AioContext changes, we need to associate a LinuxAioState with
> > > the new AioContext. Use the bdrv_attach_aio_context callback and call
> > > the new aio_setup_linux_aio(), which will allocate a new AioContext if
> > > needed, and return errors on failures. If it fails for any reason,
> > > fallback to threaded AIO with an error message, as the device is already
> > > in-use by the guest.
> > > 
> > > Signed-off-by: Nishanth Aravamudan <naravamudan@digitalocean.com>
> > > ---
> > > Note this patch didn't exist in v2, but is a result of feedback to that
> > > posting.
> > 
> > This should be squashed into patch 1, no?
> 
> Yes, without it, patch 1 is incorrect. Specifically, at least the
> assertion in aio_get_linux_aio() won't hold true without it.

Yes, you are right! Sorry about that. I'll send a v4 today.

-Nish

      reply	other threads:[~2018-06-22 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 22:21 [Qemu-devel] [PATCH v3 0/2] linux-aio: fix two NULL pointer dereferences failure paths Nishanth Aravamudan
2018-06-21 22:21 ` [Qemu-devel] [PATCH v3 1/2] linux-aio: properly bubble up errors from initialization Nishanth Aravamudan
2018-06-22  2:21   ` Fam Zheng
2018-06-22 17:12     ` Nishanth Aravamudan
2018-06-21 22:21 ` [Qemu-devel] [PATCH v3 2/2] block/file-posix: reconfigure aio on iothread start Nishanth Aravamudan
2018-06-22  2:25   ` Fam Zheng
2018-06-22  9:02     ` Kevin Wolf
2018-06-22 17:12       ` Nishanth Aravamudan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622171224.GB20261@breakout \
    --to=naravamudan@digitalocean.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.