All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: John Pittman <jpittman@redhat.com>
Cc: dm-devel@redhat.com, loberman@redhat.com
Subject: Re: dm cache: require io_mode cache feature selection to be mutually exclusive
Date: Wed, 27 Jun 2018 11:27:11 -0400	[thread overview]
Message-ID: <20180627152710.GA12017@redhat.com> (raw)
In-Reply-To: <1529616933-11644-1-git-send-email-jpittman@redhat.com>

On Thu, Jun 21 2018 at  5:35pm -0400,
John Pittman <jpittman@redhat.com> wrote:

> Due to commit 629d0a8a1a10 ("dm cache metadata: add "metadata2" feature"),
> when creating a dm cache device, more than one io_mode can be selected.
> As the io_mode selections are incompatible with one another, we should 
> force them to be selected exclusively.  Add simple ctr to check for 
> more than one io_mode selection.

I'm missing why you're associating your fix with commit 629d0a8a1a10.

Can you explain what you did to hit a problem that this patch is fixing?
Did you list conflicting modes on the ctr and the last one in the table
line won?

Thanks,
Mike

  reply	other threads:[~2018-06-27 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 21:35 [PATCH] dm cache: require io_mode cache feature selection to be mutually exclusive John Pittman
2018-06-27 15:27 ` Mike Snitzer [this message]
2018-06-27 16:01   ` John Pittman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627152710.GA12017@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=jpittman@redhat.com \
    --cc=loberman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.