From: kbuild test robot <lkp@intel.com>
To: john.hubbard@gmail.com
Cc: kbuild-all@01.org, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields
Date: Mon, 2 Jul 2018 10:11:04 +0800 [thread overview]
Message-ID: <201807020925.ScMOx4QE%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180702005654.20369-6-jhubbard@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 3228 bytes --]
Hi John,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc3]
[cannot apply to next-20180629]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125
config: i386-randconfig-x074-201826 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from include/asm-generic/atomic-instrumented.h:16:0,
from arch/x86/include/asm/atomic.h:283,
from include/linux/atomic.h:5,
from include/linux/page_counter.h:5,
from mm/memcontrol.c:34:
mm/memcontrol.c: In function 'unlock_page_lru':
>> mm/memcontrol.c:2087:32: error: 'page_tail' undeclared (first use in this function); did you mean 'page_pool'?
VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
^
include/linux/build_bug.h:36:63: note: in definition of macro 'BUILD_BUG_ON_INVALID'
#define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))
^
>> include/linux/mmdebug.h:46:36: note: in expansion of macro 'VM_BUG_ON'
#define VM_BUG_ON_PAGE(cond, page) VM_BUG_ON(cond)
^~~~~~~~~
>> mm/memcontrol.c:2087:3: note: in expansion of macro 'VM_BUG_ON_PAGE'
VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
^~~~~~~~~~~~~~
mm/memcontrol.c:2087:32: note: each undeclared identifier is reported only once for each function it appears in
VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
^
include/linux/build_bug.h:36:63: note: in definition of macro 'BUILD_BUG_ON_INVALID'
#define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))
^
>> include/linux/mmdebug.h:46:36: note: in expansion of macro 'VM_BUG_ON'
#define VM_BUG_ON_PAGE(cond, page) VM_BUG_ON(cond)
^~~~~~~~~
>> mm/memcontrol.c:2087:3: note: in expansion of macro 'VM_BUG_ON_PAGE'
VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
^~~~~~~~~~~~~~
vim +2087 mm/memcontrol.c
2077
2078 static void unlock_page_lru(struct page *page, int isolated)
2079 {
2080 struct zone *zone = page_zone(page);
2081
2082 if (isolated) {
2083 struct lruvec *lruvec;
2084
2085 lruvec = mem_cgroup_page_lruvec(page, zone->zone_pgdat);
2086 VM_BUG_ON_PAGE(PageLRU(page), page);
> 2087 VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
2088
2089 SetPageLRU(page);
2090 add_page_to_lru_list(page, lruvec, page_lru(page));
2091 }
2092 spin_unlock_irq(zone_lru_lock(zone));
2093 }
2094
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29636 bytes --]
next prev parent reply other threads:[~2018-07-02 2:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 0:56 [PATCH v2 0/6] mm/fs: gup: don't unmap or drop filesystem buffers john.hubbard
2018-07-02 0:56 ` [PATCH v2 1/6] mm: get_user_pages: consolidate error handling john.hubbard
2018-07-02 10:17 ` Jan Kara
2018-07-02 21:34 ` John Hubbard
2018-07-02 21:34 ` John Hubbard
2018-07-02 0:56 ` [PATCH v2 2/6] mm: introduce page->dma_pinned_flags, _count john.hubbard
2018-07-02 0:56 ` [PATCH v2 3/6] mm: introduce zone_gup_lock, for dma-pinned pages john.hubbard
2018-07-02 0:56 ` [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for_io() john.hubbard
2018-07-02 2:11 ` kbuild test robot
2018-07-02 4:40 ` John Hubbard
2018-07-02 4:40 ` John Hubbard
2018-07-02 2:47 ` kbuild test robot
2018-07-02 4:40 ` John Hubbard
2018-07-02 4:40 ` John Hubbard
2018-07-02 0:56 ` [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields john.hubbard
2018-07-02 2:11 ` kbuild test robot [this message]
2018-07-02 2:58 ` kbuild test robot
2018-07-02 5:05 ` John Hubbard
2018-07-02 5:05 ` John Hubbard
2018-07-02 9:53 ` Jan Kara
2018-07-02 20:43 ` John Hubbard
2018-07-02 20:43 ` John Hubbard
2018-07-03 0:08 ` Christopher Lameter
2018-07-03 4:30 ` John Hubbard
2018-07-03 4:30 ` John Hubbard
2018-07-03 17:08 ` Christopher Lameter
2018-07-03 17:36 ` John Hubbard
2018-07-03 17:36 ` John Hubbard
2018-07-03 17:48 ` Christopher Lameter
2018-07-03 18:48 ` John Hubbard
2018-07-03 18:48 ` John Hubbard
2018-07-04 10:43 ` Jan Kara
2018-07-05 14:17 ` Christopher Lameter
2018-07-09 13:49 ` Jan Kara
2018-07-02 0:56 ` [PATCH v2 6/6] mm: page_mkclean, ttu: handle pinned pages john.hubbard
2018-07-02 10:15 ` Jan Kara
2018-07-02 21:07 ` John Hubbard
2018-07-02 21:07 ` John Hubbard
2018-07-02 5:54 ` [PATCH v2 0/6] mm/fs: gup: don't unmap or drop filesystem buffers John Hubbard
2018-07-02 5:54 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807020925.ScMOx4QE%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.