From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC40C6778A for ; Tue, 3 Jul 2018 14:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE59C23F2A for ; Tue, 3 Jul 2018 14:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="cY2Pf4J0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE59C23F2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbeGCOPm (ORCPT ); Tue, 3 Jul 2018 10:15:42 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34411 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753467AbeGCOPk (ORCPT ); Tue, 3 Jul 2018 10:15:40 -0400 Received: by mail-pf0-f196.google.com with SMTP id e10-v6so1099169pfn.1 for ; Tue, 03 Jul 2018 07:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gyvfJtUPmf4Af7JGqkoAVx99gOQJn2H8Pw8w7k7gOCc=; b=cY2Pf4J0THis3VYa5/Sp3mgVm2Hh1DvnzNdter5r3zTEchZTGcWEZzHuZPtCXH/B96 JukT6nEAUJHS542d3zhGE3Ex0A/O7peou5EGEZcHAGnZZrHWNJSU3DgxmJjYXzEZ5fmv 04TpRTYR8/yScWA4BIOcOBUSrB+UhQra5SA40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gyvfJtUPmf4Af7JGqkoAVx99gOQJn2H8Pw8w7k7gOCc=; b=qo/t/vkZPm7VWYVkALEENjoI/wCP2zBHIu5D857PSO6TxkwgXwql07grTWkiII/CxW lDtXOyv4zaupLwZu3MdjqGdofj7xD36qkdxvHydkq8ktMDK/orx5u6yGnzspfLsYjc16 fEbNznTzWbOoXwQmq9UM/8WND86ucSdMzuCHorX1BHJLhuWDqSRa4rKdb3kSkFCh4J0G P9zjj/XupADRBXbd1184+EzM3tV1ZNxXzHGVSl+FyVc1WDyhh7/CZhBlbhmI3Mir7ITA CGHIZOqRL7XEkmhmohFGLuUxb1PRN5+0r0zpLHfIrAcQdM1JNls2eI4fHL4jnEcr8cDc yumw== X-Gm-Message-State: APt69E0zBMaHyLhG5DHtHe8CXrjmWVqC+lJQuwjHUZxnezZgsHZePEqt 8sSKTYfdGzNhiYBoZok36CPpQuqqzOE= X-Google-Smtp-Source: AAOMgpcZKAVVdnqqKXtLZ7bUTI3a58sflfB9cbTKDrnojKAAv4fwcVQU72U8V4Uw9eWOGePNfAyH+Q== X-Received: by 2002:a62:d444:: with SMTP id u4-v6mr454958pfl.142.1530627339038; Tue, 03 Jul 2018 07:15:39 -0700 (PDT) Received: from localhost ([2620:0:1000:1600:3122:ea9c:d178:eb]) by smtp.gmail.com with ESMTPSA id d9-v6sm3314302pfb.92.2018.07.03.07.15.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 07:15:38 -0700 (PDT) Date: Tue, 3 Jul 2018 07:15:37 -0700 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Boqun Feng , Byungchul Park , Ingo Molnar , Julia Cartwright , linux-kselftest@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Namhyung Kim , Paul McKenney , Peter Zijlstra , Steven Rostedt , Thomas Glexiner , Tom Zanussi Subject: Re: [PATCH v9 0/7] Centralize and unify usage of preempt/irq tracepoints Message-ID: <20180703141537.GA108396@joelaf.mtv.corp.google.com> References: <20180628182149.226164-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180628182149.226164-1-joel@joelfernandes.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 28, 2018 at 11:21:42AM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > This is a posting of v9 preempt/irq tracepoint clean up series rebased > onto v4.18-rc2. No changes in the series, just a rebase + repost. > > All patches have a Reviewed-by tags now from reviewers. This series has > been well tested and is a simplification/refactoring of existing code, > along with giving a speed-up for tracepoints using the rcu-idle API. > With this our users will find it easier to use tools depending on > existing preempt tracepoints since it simplifies the configuration for > them. Steve, all patches of this tracing series have been reviewed and/or acked and there haven't been additional changes for a couple of reposts. Are you Ok with it? Thanks, -Joel > Future enhancements/fixes I am developing for preempt-off tracer will > depend on these patches, so I suggest prioritizing these well reviewed > and tested patches for that reason as well. > > Introduction to the series: > The preempt/irq tracepoints exist but not everything in the kernel is using it > whenever they need to be notified that a preempt disable/enable or an irq > disable/enable has occurred. This makes things not work simultaneously (for > example, only either lockdep or irqsoff trace-events can be used at a time). > > This is particularly painful to deal with, since turning on lockdep breaks > tracers that install probes on IRQ events, such as the BCC atomic critical > section tracer [1]. This constraint also makes it impossible to use synthetic > events to trace irqsoff sections with lockdep simulataneously turned on. > > This series solves that, and also results in a nice clean up of relevant parts > of the kernel. Several ifdefs are simpler, and the design is more unified and > better. Also as a result of this, we also speeded performance all rcuidle > tracepoints since their handling is simpler. > > [1] https://github.com/iovisor/bcc/blob/master/tools/criticalstat_example.txt > > v8->v9: > - Small style changes to tracepoint code (Mathieu) > - Minor style fix to use PTR_ERR_OR_ZERO (0-day bot) > - Minor fix to test_atomic_sections to use unsigned long. > - Added Namhyung's, Mathieu's Reviewed-by to some patches. > - Added Acks from Matsami > > v7->v8: > - Refactored irqsoff tracer probe defines (Namhyung) > > v6->v7: > - Added a module to simulate an atomic section, a kselftest to load and > and trigger it which verifies the preempt-tracer and this series. > > - Fixed a new warning after I rebased in early boot, this is because > early_boot_irqs_disabled was set too early, I moved it after the lockdep > initialization. > > - added back the softirq fix since it appears it wasn't picked up. > > - Ran Ingo's locking API selftest suite which are passing with this > series. > > - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister > function incase tracepoints aren't enabled, did that. > > > Joel Fernandes (Google) (6): > srcu: Add notrace variant of srcu_dereference > trace/irqsoff: Split reset into separate functions > tracepoint: Make rcuidle tracepoint callers use SRCU > tracing: Centralize preemptirq tracepoints and unify their usage > lib: Add module to simulate atomic sections for testing preemptoff > tracers > kselftests: Add tests for the preemptoff and irqsoff tracers > > Paul McKenney (1): > srcu: Add notrace variants of srcu_read_{lock,unlock} > > include/linux/ftrace.h | 11 +- > include/linux/irqflags.h | 11 +- > include/linux/lockdep.h | 8 +- > include/linux/preempt.h | 2 +- > include/linux/srcu.h | 22 ++ > include/linux/tracepoint.h | 49 +++- > include/trace/events/preemptirq.h | 23 +- > init/main.c | 5 +- > kernel/locking/lockdep.c | 35 +-- > kernel/sched/core.c | 2 +- > kernel/trace/Kconfig | 22 +- > kernel/trace/Makefile | 2 +- > kernel/trace/trace_irqsoff.c | 253 ++++++------------ > kernel/trace/trace_preemptirq.c | 71 +++++ > kernel/tracepoint.c | 16 +- > lib/Kconfig.debug | 8 + > lib/Makefile | 1 + > lib/test_atomic_sections.c | 77 ++++++ > tools/testing/selftests/ftrace/config | 3 + > .../test.d/preemptirq/irqsoff_tracer.tc | 73 +++++ > 20 files changed, 453 insertions(+), 241 deletions(-) > create mode 100644 kernel/trace/trace_preemptirq.c > create mode 100644 lib/test_atomic_sections.c > create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > > -- > 2.18.0.rc2.346.g013aa6912e-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: joel at joelfernandes.org (Joel Fernandes) Date: Tue, 3 Jul 2018 07:15:37 -0700 Subject: [PATCH v9 0/7] Centralize and unify usage of preempt/irq tracepoints In-Reply-To: <20180628182149.226164-1-joel@joelfernandes.org> References: <20180628182149.226164-1-joel@joelfernandes.org> Message-ID: <20180703141537.GA108396@joelaf.mtv.corp.google.com> On Thu, Jun 28, 2018 at 11:21:42AM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > This is a posting of v9 preempt/irq tracepoint clean up series rebased > onto v4.18-rc2. No changes in the series, just a rebase + repost. > > All patches have a Reviewed-by tags now from reviewers. This series has > been well tested and is a simplification/refactoring of existing code, > along with giving a speed-up for tracepoints using the rcu-idle API. > With this our users will find it easier to use tools depending on > existing preempt tracepoints since it simplifies the configuration for > them. Steve, all patches of this tracing series have been reviewed and/or acked and there haven't been additional changes for a couple of reposts. Are you Ok with it? Thanks, -Joel > Future enhancements/fixes I am developing for preempt-off tracer will > depend on these patches, so I suggest prioritizing these well reviewed > and tested patches for that reason as well. > > Introduction to the series: > The preempt/irq tracepoints exist but not everything in the kernel is using it > whenever they need to be notified that a preempt disable/enable or an irq > disable/enable has occurred. This makes things not work simultaneously (for > example, only either lockdep or irqsoff trace-events can be used at a time). > > This is particularly painful to deal with, since turning on lockdep breaks > tracers that install probes on IRQ events, such as the BCC atomic critical > section tracer [1]. This constraint also makes it impossible to use synthetic > events to trace irqsoff sections with lockdep simulataneously turned on. > > This series solves that, and also results in a nice clean up of relevant parts > of the kernel. Several ifdefs are simpler, and the design is more unified and > better. Also as a result of this, we also speeded performance all rcuidle > tracepoints since their handling is simpler. > > [1] https://github.com/iovisor/bcc/blob/master/tools/criticalstat_example.txt > > v8->v9: > - Small style changes to tracepoint code (Mathieu) > - Minor style fix to use PTR_ERR_OR_ZERO (0-day bot) > - Minor fix to test_atomic_sections to use unsigned long. > - Added Namhyung's, Mathieu's Reviewed-by to some patches. > - Added Acks from Matsami > > v7->v8: > - Refactored irqsoff tracer probe defines (Namhyung) > > v6->v7: > - Added a module to simulate an atomic section, a kselftest to load and > and trigger it which verifies the preempt-tracer and this series. > > - Fixed a new warning after I rebased in early boot, this is because > early_boot_irqs_disabled was set too early, I moved it after the lockdep > initialization. > > - added back the softirq fix since it appears it wasn't picked up. > > - Ran Ingo's locking API selftest suite which are passing with this > series. > > - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister > function incase tracepoints aren't enabled, did that. > > > Joel Fernandes (Google) (6): > srcu: Add notrace variant of srcu_dereference > trace/irqsoff: Split reset into separate functions > tracepoint: Make rcuidle tracepoint callers use SRCU > tracing: Centralize preemptirq tracepoints and unify their usage > lib: Add module to simulate atomic sections for testing preemptoff > tracers > kselftests: Add tests for the preemptoff and irqsoff tracers > > Paul McKenney (1): > srcu: Add notrace variants of srcu_read_{lock,unlock} > > include/linux/ftrace.h | 11 +- > include/linux/irqflags.h | 11 +- > include/linux/lockdep.h | 8 +- > include/linux/preempt.h | 2 +- > include/linux/srcu.h | 22 ++ > include/linux/tracepoint.h | 49 +++- > include/trace/events/preemptirq.h | 23 +- > init/main.c | 5 +- > kernel/locking/lockdep.c | 35 +-- > kernel/sched/core.c | 2 +- > kernel/trace/Kconfig | 22 +- > kernel/trace/Makefile | 2 +- > kernel/trace/trace_irqsoff.c | 253 ++++++------------ > kernel/trace/trace_preemptirq.c | 71 +++++ > kernel/tracepoint.c | 16 +- > lib/Kconfig.debug | 8 + > lib/Makefile | 1 + > lib/test_atomic_sections.c | 77 ++++++ > tools/testing/selftests/ftrace/config | 3 + > .../test.d/preemptirq/irqsoff_tracer.tc | 73 +++++ > 20 files changed, 453 insertions(+), 241 deletions(-) > create mode 100644 kernel/trace/trace_preemptirq.c > create mode 100644 lib/test_atomic_sections.c > create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > > -- > 2.18.0.rc2.346.g013aa6912e-goog > > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: joel@joelfernandes.org (Joel Fernandes) Date: Tue, 3 Jul 2018 07:15:37 -0700 Subject: [PATCH v9 0/7] Centralize and unify usage of preempt/irq tracepoints In-Reply-To: <20180628182149.226164-1-joel@joelfernandes.org> References: <20180628182149.226164-1-joel@joelfernandes.org> Message-ID: <20180703141537.GA108396@joelaf.mtv.corp.google.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180703141537.3_2IdsAeAK4uFUSzmzhMMWJrrMOlLfRAe84yE-YSd0E@z> On Thu, Jun 28, 2018@11:21:42AM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > This is a posting of v9 preempt/irq tracepoint clean up series rebased > onto v4.18-rc2. No changes in the series, just a rebase + repost. > > All patches have a Reviewed-by tags now from reviewers. This series has > been well tested and is a simplification/refactoring of existing code, > along with giving a speed-up for tracepoints using the rcu-idle API. > With this our users will find it easier to use tools depending on > existing preempt tracepoints since it simplifies the configuration for > them. Steve, all patches of this tracing series have been reviewed and/or acked and there haven't been additional changes for a couple of reposts. Are you Ok with it? Thanks, -Joel > Future enhancements/fixes I am developing for preempt-off tracer will > depend on these patches, so I suggest prioritizing these well reviewed > and tested patches for that reason as well. > > Introduction to the series: > The preempt/irq tracepoints exist but not everything in the kernel is using it > whenever they need to be notified that a preempt disable/enable or an irq > disable/enable has occurred. This makes things not work simultaneously (for > example, only either lockdep or irqsoff trace-events can be used at a time). > > This is particularly painful to deal with, since turning on lockdep breaks > tracers that install probes on IRQ events, such as the BCC atomic critical > section tracer [1]. This constraint also makes it impossible to use synthetic > events to trace irqsoff sections with lockdep simulataneously turned on. > > This series solves that, and also results in a nice clean up of relevant parts > of the kernel. Several ifdefs are simpler, and the design is more unified and > better. Also as a result of this, we also speeded performance all rcuidle > tracepoints since their handling is simpler. > > [1] https://github.com/iovisor/bcc/blob/master/tools/criticalstat_example.txt > > v8->v9: > - Small style changes to tracepoint code (Mathieu) > - Minor style fix to use PTR_ERR_OR_ZERO (0-day bot) > - Minor fix to test_atomic_sections to use unsigned long. > - Added Namhyung's, Mathieu's Reviewed-by to some patches. > - Added Acks from Matsami > > v7->v8: > - Refactored irqsoff tracer probe defines (Namhyung) > > v6->v7: > - Added a module to simulate an atomic section, a kselftest to load and > and trigger it which verifies the preempt-tracer and this series. > > - Fixed a new warning after I rebased in early boot, this is because > early_boot_irqs_disabled was set too early, I moved it after the lockdep > initialization. > > - added back the softirq fix since it appears it wasn't picked up. > > - Ran Ingo's locking API selftest suite which are passing with this > series. > > - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister > function incase tracepoints aren't enabled, did that. > > > Joel Fernandes (Google) (6): > srcu: Add notrace variant of srcu_dereference > trace/irqsoff: Split reset into separate functions > tracepoint: Make rcuidle tracepoint callers use SRCU > tracing: Centralize preemptirq tracepoints and unify their usage > lib: Add module to simulate atomic sections for testing preemptoff > tracers > kselftests: Add tests for the preemptoff and irqsoff tracers > > Paul McKenney (1): > srcu: Add notrace variants of srcu_read_{lock,unlock} > > include/linux/ftrace.h | 11 +- > include/linux/irqflags.h | 11 +- > include/linux/lockdep.h | 8 +- > include/linux/preempt.h | 2 +- > include/linux/srcu.h | 22 ++ > include/linux/tracepoint.h | 49 +++- > include/trace/events/preemptirq.h | 23 +- > init/main.c | 5 +- > kernel/locking/lockdep.c | 35 +-- > kernel/sched/core.c | 2 +- > kernel/trace/Kconfig | 22 +- > kernel/trace/Makefile | 2 +- > kernel/trace/trace_irqsoff.c | 253 ++++++------------ > kernel/trace/trace_preemptirq.c | 71 +++++ > kernel/tracepoint.c | 16 +- > lib/Kconfig.debug | 8 + > lib/Makefile | 1 + > lib/test_atomic_sections.c | 77 ++++++ > tools/testing/selftests/ftrace/config | 3 + > .../test.d/preemptirq/irqsoff_tracer.tc | 73 +++++ > 20 files changed, 453 insertions(+), 241 deletions(-) > create mode 100644 kernel/trace/trace_preemptirq.c > create mode 100644 lib/test_atomic_sections.c > create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > > -- > 2.18.0.rc2.346.g013aa6912e-goog > > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html