All of lore.kernel.org
 help / color / mirror / Atom feed
From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "kernel@collabora.com" <kernel@collabora.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.
Date: Wed, 04 Jul 2018 09:59:18 +0900	[thread overview]
Message-ID: <20180704005918epcms1p6c43766664c42fac3ee4d7eb7375b43eb@epcms1p6> (raw)
In-Reply-To: <20180703132931.14389-1-enric.balletbo@collabora.com>

>+		if (!strncmp(name, DEVFREQ_GOV_SIMPLE_ONDEMAND,
>+			     DEVFREQ_NAME_LEN))
>+			err = request_module("governor_%s", "simpleondemand");
>+		else
>+			err = request_module("governor_%s", name);
>+		if (err)
>+			return NULL;

You are returning without the lock acquired..

  parent reply	other threads:[~2018-07-04  0:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180703132943epcas1p25b68c00ca1143d5eabcc2285c2ce27a0@epcas1p2.samsung.com>
2018-07-03 13:29 ` [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules Enric Balletbo i Serra
     [not found]   ` <CGME20180703132943epcas1p25b68c00ca1143d5eabcc2285c2ce27a0@epcms1p6>
2018-07-04  0:59     ` MyungJoo Ham [this message]
2018-07-04  1:06   ` Chanwoo Choi
2018-07-04  8:16     ` Enric Balletbo i Serra
2018-07-04  8:26       ` Chanwoo Choi
2018-07-04  8:32         ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704005918epcms1p6c43766664c42fac3ee4d7eb7375b43eb@epcms1p6 \
    --to=myungjoo.ham@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=enric.balletbo@collabora.com \
    --cc=kernel@collabora.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.