All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Todd Poynor <toddpoynor@gmail.com>
Cc: Dmitry Torokhov <dtor@chromium.org>,
	devel@driverdev.osuosl.org, Zhongze Hu <frankhu@chromium.org>,
	John Joseph <jnjoseph@google.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Simon Que <sque@chromium.org>,
	Rob Springer <rspringer@google.com>,
	Guenter Roeck <groeck@chromium.org>,
	Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH 11/18] staging: gasket: always allow root open for write
Date: Sun, 15 Jul 2018 21:41:50 +0200	[thread overview]
Message-ID: <20180715194150.GC2288@kroah.com> (raw)
In-Reply-To: <CAO3upoZeTGDZsGaYGhmQE_7GaihLYPym6miD9vMWM5Fzi46GMA@mail.gmail.com>

On Sun, Jul 15, 2018 at 11:15:26AM -0700, Todd Poynor wrote:
> On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote:
> >> > I can't wait for people to just realize this whole "new" subsystem can
> >> > be replaced with UIO, but that's a topic for a different thread...
> >>
> >> Yes, that is true and that is why I am not sure why we are going
> >> through all this staging exercise.
> >>
> >> As far as I understand we'd still need to have quite a bit of kernel
> >> code so that we can safely program DMA controller (it does not look
> >> like uio_dmem_genirq.c is sufficient as is for gasket needs), but that
> >> should be solvable.
> >
> > I agree, it should be solvable, and much smaller and simpler than this
> > whole large chunk of "subsystem+driver" code.  But I'm not the one
> > having to do this work, and it provides a bunch of easy cleanups for
> > people looking to get into kernel development, so I don't mind :)
> >
> > But the "maintainers" should keep this in mind, as it is, this code is
> > _not_ acceptable for the main kernel tree because of the UIO framework
> > already present.
> 
> My own preference is to rewrite the apex driver entirely in-kernel and
> pull in its userspace parts here.  If I don't receive significant
> pushback on that I'll start doing that real soon.

Why would we object to that?


  reply	other threads:[~2018-07-15 19:41 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-14  5:57 [PATCH 00/18] staging: gasket: sundry fixes and fixups Todd Poynor
2018-07-14  5:57 ` [PATCH 01/18] staging: gasket: remove X86 Kconfig restriction Todd Poynor
2018-07-14  5:58 ` [PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket Todd Poynor
2018-07-14  6:28   ` Greg Kroah-Hartman
2018-07-14  5:58 ` [PATCH 03/18] staging: gasket: typo and whitespace cleanups Todd Poynor
2018-07-14  6:31   ` Greg Kroah-Hartman
2018-07-14  5:58 ` [PATCH 04/18] staging: gasket: device registration error and unregister fixups Todd Poynor
2018-07-16 13:53   ` Dan Carpenter
2018-07-16 21:15     ` Todd Poynor
2018-07-14  5:58 ` [PATCH 05/18] staging: gasket: sysfs mapping creation fixups Todd Poynor
2018-07-14  6:32   ` Greg Kroah-Hartman
2018-07-16 21:14     ` Todd Poynor
2018-07-17  6:55       ` Greg Kroah-Hartman
2018-07-14  5:58 ` [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path Todd Poynor
2018-07-14  6:36   ` Greg Kroah-Hartman
2018-07-14  8:07   ` Dmitry Torokhov
2018-07-14 12:57     ` Greg Kroah-Hartman
2018-07-16 21:16       ` Todd Poynor
2018-07-14  5:58 ` [PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return Todd Poynor
2018-07-14  5:58 ` [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups Todd Poynor
2018-07-14  6:33   ` Greg Kroah-Hartman
2018-07-14  5:58 ` [PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error Todd Poynor
2018-07-14  5:58 ` [PATCH 10/18] staging: gasket: gasket_open use container_of() Todd Poynor
2018-07-14  8:15   ` Dmitry Torokhov
2018-07-16 21:18     ` Todd Poynor
2018-07-14  5:58 ` [PATCH 11/18] staging: gasket: always allow root open for write Todd Poynor
2018-07-14  8:25   ` Dmitry Torokhov
2018-07-16 21:22     ` Todd Poynor
2018-07-15  9:05   ` Greg Kroah-Hartman
2018-07-15  9:11     ` Dmitry Torokhov
2018-07-15  9:32       ` Greg Kroah-Hartman
2018-07-15  9:53         ` Dmitry Torokhov
2018-07-15 10:03           ` Greg Kroah-Hartman
2018-07-15 18:15             ` Todd Poynor
2018-07-15 19:41               ` Greg Kroah-Hartman [this message]
2018-07-16 21:26                 ` Todd Poynor
2018-07-14  5:58 ` [PATCH 12/18] staging: gasket: annotate ioctl arg with __user Todd Poynor
2018-07-14  6:35   ` Greg Kroah-Hartman
     [not found]     ` <CAO3upobyf9JpKLSoSPeVfNGOh6R0cud=hT+bhA=U2kNkGEJ-aw@mail.gmail.com>
2018-07-14  7:44       ` Greg Kroah-Hartman
2018-07-14 19:20         ` Todd Poynor
2018-07-15  9:00           ` Greg Kroah-Hartman
2018-07-15 17:38             ` Todd Poynor
2018-07-14  5:58 ` [PATCH 13/18] staging: gasket: gasket_enable_dev fixups Todd Poynor
2018-07-14  6:39   ` Greg Kroah-Hartman
2018-07-16 21:28     ` Todd Poynor
2018-07-14  5:58 ` [PATCH 14/18] staging: gasket: fix class create bug handling Todd Poynor
2018-07-14  8:16   ` Dmitry Torokhov
2018-07-14  5:58 ` [PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator Todd Poynor
2018-07-14  5:58 ` [PATCH 16/18] staging: gasket: gasket core error handling fixups Todd Poynor
2018-07-14  5:58 ` [PATCH 17/18] staging: gasket: don't release coherent mappings Todd Poynor
2018-07-14  5:58 ` [PATCH 18/18] staging: gasket: various cleanups Todd Poynor
2018-07-14  6:30   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180715194150.GC2288@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dtor@chromium.org \
    --cc=frankhu@chromium.org \
    --cc=groeck@chromium.org \
    --cc=jnjoseph@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rspringer@google.com \
    --cc=sque@chromium.org \
    --cc=toddpoynor@gmail.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.