From: David Miller <davem@davemloft.net>
To: vakul.garg@nxp.com
Cc: netdev@vger.kernel.org, borisp@mellanox.com,
aviadye@mellanox.com, davejwatson@fb.com
Subject: Re: [net-next v5 3/3] net/tls: Remove redundant array allocation.
Date: Sat, 21 Jul 2018 19:25:32 -0700 (PDT) [thread overview]
Message-ID: <20180721.192532.520509909556885779.davem@davemloft.net> (raw)
In-Reply-To: <20180719162613.27184-4-vakul.garg@nxp.com>
From: Vakul Garg <vakul.garg@nxp.com>
Date: Thu, 19 Jul 2018 21:56:13 +0530
> In function decrypt_skb(), array allocation in case when sgout is NULL
> is unnecessary. Instead, local variable sgin_arr[] can be used.
>
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Hmmm...
Dave, can you take a look at this? Do you think there might have
been a reason you felt that you needed to dynamically allocate
the scatterlists when you COW and skb and do in-place decryption?
I guess this change is ok, nsg can only get smaller when the SKB
is COW'd.
next prev parent reply other threads:[~2018-07-22 3:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 16:26 [net-next v5 0/3] net/tls: Minor code cleanup patches Vakul Garg
2018-07-19 16:26 ` [net-next v5 1/3] net/tls: Use socket data_ready callback on record availability Vakul Garg
2018-07-19 16:26 ` [net-next v5 2/3] net/tls: Remove redundant variable assignments and wakeup Vakul Garg
2018-07-19 16:26 ` [net-next v5 3/3] net/tls: Remove redundant array allocation Vakul Garg
2018-07-22 2:25 ` David Miller [this message]
2018-07-23 16:35 ` Dave Watson
2018-07-24 4:41 ` David Miller
2018-07-24 4:43 ` Vakul Garg
2018-07-24 4:49 ` David Miller
2018-07-24 8:22 ` Vakul Garg
2018-07-25 21:01 ` Dave Watson
2018-07-27 9:34 ` Vakul Garg
2018-07-27 15:38 ` Dave Watson
2018-08-01 13:49 ` Vakul Garg
2018-08-01 20:52 ` Dave Watson
-- strict thread matches above, loose matches on Subject: below --
2018-07-19 16:23 [net-next v4 0/3] net/tls: Minor code cleanup patches Vakul Garg
2018-07-19 16:23 ` [net-next v5 3/3] net/tls: Remove redundant array allocation Vakul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721.192532.520509909556885779.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.