Hi huijin.park, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on block/for-next] [cannot apply to v4.18-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Huijin-Park/genhd-incrase-size-of-disk-stat-counters/20180731-173548 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=parisc All warnings (new ones prefixed by >>): block/genhd.c: In function 'diskstats_show': >> block/genhd.c:1373:1: warning: the frame size of 1584 bytes is larger than 1280 bytes [-Wframe-larger-than=] } ^ vim +1373 block/genhd.c ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1304 a6e2ba88 block/genhd.c Randy Dunlap 2008-05-23 1305 #ifdef CONFIG_PROC_FS cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1306 /* cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1307 * aggregate disk stat collector. Uses the same stats that the sysfs cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1308 * entries do, above, but makes them available through one seq_file. cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1309 * cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1310 * The output looks suspiciously like /proc/partitions with a bunch of cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1311 * extra fields. cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1312 */ cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1313 static int diskstats_show(struct seq_file *seqf, void *v) ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1314 { ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1315 struct gendisk *gp = v; e71bf0d0 block/genhd.c Tejun Heo 2008-09-03 1316 struct disk_part_iter piter; e71bf0d0 block/genhd.c Tejun Heo 2008-09-03 1317 struct hd_struct *hd; ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1318 char buf[BDEVNAME_SIZE]; 0609e0ef block/genhd.c Jens Axboe 2017-08-08 1319 unsigned int inflight[2]; c9959059 block/genhd.c Tejun Heo 2008-08-25 1320 int cpu; ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1321 ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1322 /* ed9e1982 block/genhd.c Tejun Heo 2008-08-25 1323 if (&disk_to_dev(gp)->kobj.entry == block_class.devices.next) cf771cb5 block/genhd.c Tejun Heo 2008-09-03 1324 seq_puts(seqf, "major minor name" ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1325 " rio rmerge rsect ruse wio wmerge " ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1326 "wsect wuse running use aveq" ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1327 "\n\n"); ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1328 */ ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1329 71982a40 block/genhd.c Tejun Heo 2009-04-17 1330 disk_part_iter_init(&piter, gp, DISK_PITER_INCL_EMPTY_PART0); e71bf0d0 block/genhd.c Tejun Heo 2008-09-03 1331 while ((hd = disk_part_iter_next(&piter))) { 074a7aca block/genhd.c Tejun Heo 2008-08-25 1332 cpu = part_stat_lock(); d62e26b3 block/genhd.c Jens Axboe 2017-06-30 1333 part_round_stats(gp->queue, cpu, hd); 074a7aca block/genhd.c Tejun Heo 2008-08-25 1334 part_stat_unlock(); 0609e0ef block/genhd.c Jens Axboe 2017-08-08 1335 part_in_flight(gp->queue, hd, inflight); bdca3c87 block/genhd.c Michael Callahan 2018-07-18 1336 seq_printf(seqf, "%4d %7d %s " 0d71c7ce block/genhd.c huijin.park 2018-07-30 1337 "%llu %llu %llu %llu " 0d71c7ce block/genhd.c huijin.park 2018-07-30 1338 "%llu %llu %llu %llu " 0d71c7ce block/genhd.c huijin.park 2018-07-30 1339 "%u %llu %llu " 0d71c7ce block/genhd.c huijin.park 2018-07-30 1340 "%llu %llu %llu %llu\n", f331c029 block/genhd.c Tejun Heo 2008-09-03 1341 MAJOR(part_devt(hd)), MINOR(part_devt(hd)), f331c029 block/genhd.c Tejun Heo 2008-09-03 1342 disk_name(gp, hd->partno, buf), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1343 part_stat_read(hd, ios[STAT_READ]), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1344 part_stat_read(hd, merges[STAT_READ]), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1345 part_stat_read(hd, sectors[STAT_READ]), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1346 div_u64(jiffies64_to_nsecs(part_stat_read(hd, 0d71c7ce block/genhd.c huijin.park 2018-07-30 1347 ticks[STAT_READ])), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1348 NSEC_PER_MSEC), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1349 part_stat_read(hd, ios[STAT_WRITE]), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1350 part_stat_read(hd, merges[STAT_WRITE]), dbae2c55 block/genhd.c Michael Callahan 2018-07-18 1351 part_stat_read(hd, sectors[STAT_WRITE]), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1352 div_u64(jiffies64_to_nsecs(part_stat_read(hd, 0d71c7ce block/genhd.c huijin.park 2018-07-30 1353 ticks[STAT_WRITE])), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1354 NSEC_PER_MSEC), 0609e0ef block/genhd.c Jens Axboe 2017-08-08 1355 inflight[0], 0d71c7ce block/genhd.c huijin.park 2018-07-30 1356 div_u64(jiffies64_to_nsecs(part_stat_read(hd, 0d71c7ce block/genhd.c huijin.park 2018-07-30 1357 io_ticks)), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1358 NSEC_PER_MSEC), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1359 div_u64(jiffies64_to_nsecs(part_stat_read(hd, 0d71c7ce block/genhd.c huijin.park 2018-07-30 1360 time_in_queue)), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1361 NSEC_PER_MSEC), bdca3c87 block/genhd.c Michael Callahan 2018-07-18 1362 part_stat_read(hd, ios[STAT_DISCARD]), bdca3c87 block/genhd.c Michael Callahan 2018-07-18 1363 part_stat_read(hd, merges[STAT_DISCARD]), bdca3c87 block/genhd.c Michael Callahan 2018-07-18 1364 part_stat_read(hd, sectors[STAT_DISCARD]), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1365 div_u64(jiffies64_to_nsecs(part_stat_read(hd, 0d71c7ce block/genhd.c huijin.park 2018-07-30 1366 ticks[STAT_DISCARD])), 0d71c7ce block/genhd.c huijin.park 2018-07-30 1367 NSEC_PER_MSEC) 28f39d55 block/genhd.c Jerome Marchand 2008-02-08 1368 ); ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1369 } e71bf0d0 block/genhd.c Tejun Heo 2008-09-03 1370 disk_part_iter_exit(&piter); ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1371 ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1372 return 0; ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 @1373 } ^1da177e drivers/block/genhd.c Linus Torvalds 2005-04-16 1374 :::::: The code at line 1373 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation