From: Doron Roberts-Kedes <doronrk@fb.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Tom Herbert <tom@quantonium.net>,
Dave Watson <davejwatson@fb.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] strparser: remove any offset before parsing messages
Date: Tue, 21 Aug 2018 14:15:22 -0700 [thread overview]
Message-ID: <20180821211504.GA76892@doronrk-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20180821193655.GA15354@nautica>
On Tue, Aug 21, 2018 at 09:36:55PM +0200, Dominique Martinet wrote:
> One of the solutions I had suggested was adding a flag at strparser
> setup time to only do that pull for users which cannot handle offset,
> but nobody seemed interested two weeks ago. I can still do that.
This seems overly complicated.
> That's still suboptimal, but I don't have any better idea.
> To properly fix the users, I'd really need help with how bpf works to
> even know if passing an offset would be possible in the first place, as
> I do not see how at this time.
Thanks for clarifying Dominique.
It seems like we mainly agree that the proposed patch is suboptimal for
existing clients of the library that use offset correctly (tls).
It also seems like you've identified that the proper fix is in bpf.
Regrettably, I cannot help you understand how bpf works because I'm not
familiar with that code.
As an aside, I would recommend reaching the netdev FAQ page:
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
It contains helpful hints about how to format email subjects (specifying
net vs. net-next) and determining when trees are closed (currently
closed).
next prev parent reply other threads:[~2018-08-21 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 22:40 [PATCH v0] strparser: remove any offset before parsing messages Dominique Martinet
2018-08-21 12:51 ` [PATCH] " Dominique Martinet
2018-08-21 14:53 ` Doron Roberts-Kedes
2018-08-21 19:36 ` Dominique Martinet
2018-08-21 21:15 ` Doron Roberts-Kedes [this message]
2018-08-21 22:51 ` Dominique Martinet
2018-08-21 23:35 ` Doron Roberts-Kedes
2018-08-22 0:46 ` Dominique Martinet
2018-08-22 2:33 ` Doron Roberts-Kedes
2018-08-22 5:47 ` Dominique Martinet
2018-08-22 18:38 ` Dave Watson
2018-08-23 1:04 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821211504.GA76892@doronrk-mbp.dhcp.thefacebook.com \
--to=doronrk@fb.com \
--cc=asmadeus@codewreck.org \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.