From: kbuild test robot <lkp@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: kbuild-all@01.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
stable@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] x86/speculation/l1tf: suggest what to do on systems with too much RAM
Date: Fri, 24 Aug 2018 03:23:31 +0800 [thread overview]
Message-ID: <201808240332.3LTpGFNW%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180823142812.7363-1-vbabka@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 2804 bytes --]
Hi Vlastimil,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/auto-latest]
[also build test ERROR on next-20180822]
[cannot apply to v4.18]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vlastimil-Babka/x86-speculation-l1tf-suggest-what-to-do-on-systems-with-too-much-RAM/20180824-013859
config: i386-randconfig-a1-201833 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:14:0,
from arch/x86/include/asm/percpu.h:45,
from arch/x86/include/asm/current.h:6,
from include/linux/sched.h:12,
from include/linux/utsname.h:6,
from arch/x86//kernel/cpu/bugs.c:12:
arch/x86//kernel/cpu/bugs.c: In function 'l1tf_select_mitigation':
>> arch/x86//kernel/cpu/bugs.c:709:12: error: 'max_pfn' undeclared (first use in this function)
((u64) max_pfn << PAGE_SHIFT) - half_pa);
^
include/linux/printk.h:311:34: note: in definition of macro 'pr_info'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
arch/x86//kernel/cpu/bugs.c:709:12: note: each undeclared identifier is reported only once for each function it appears in
((u64) max_pfn << PAGE_SHIFT) - half_pa);
^
include/linux/printk.h:311:34: note: in definition of macro 'pr_info'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
vim +/max_pfn +709 arch/x86//kernel/cpu/bugs.c
697
698 /*
699 * This is extremely unlikely to happen because almost all
700 * systems have far more MAX_PA/2 than RAM can be fit into
701 * DIMM slots.
702 */
703 half_pa = (u64)l1tf_pfn_limit() << PAGE_SHIFT;
704 if (e820__mapped_any(half_pa, ULLONG_MAX - half_pa, E820_TYPE_RAM)) {
705 pr_warn("System has more than MAX_PA/2 memory. L1TF mitigation not effective.\n");
706 pr_info("You may make it effective by booting the kernel with mem=%llu parameter.\n",
707 half_pa);
708 pr_info("However, doing so will make up to %llu bytes of RAM unusable.\n",
> 709 ((u64) max_pfn << PAGE_SHIFT) - half_pa);
710 pr_info("Reading Documentation/admin-guide/l1tf.rst might help you decide.");
711 return;
712 }
713
714 setup_force_cpu_cap(X86_FEATURE_L1TF_PTEINV);
715 }
716
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23873 bytes --]
next prev parent reply other threads:[~2018-08-23 19:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 13:44 [PATCH] x86/speculation/l1tf: fix off-by-one error when warning that system has too much RAM Vlastimil Babka
2018-08-23 13:56 ` Michal Hocko
2018-08-23 14:28 ` [PATCH] x86/speculation/l1tf: suggest what to do on systems with " Vlastimil Babka
2018-08-23 15:46 ` Andi Kleen
2018-08-23 19:25 ` Michal Hocko
2018-08-23 19:38 ` Andi Kleen
2018-08-23 20:05 ` Michal Hocko
2018-08-23 22:07 ` Andi Kleen
2018-08-23 19:03 ` kbuild test robot
2018-08-23 19:23 ` kbuild test robot [this message]
2018-08-23 19:27 ` Michal Hocko
2018-08-24 7:32 ` Vlastimil Babka
2018-08-24 7:32 ` Vlastimil Babka
2018-08-24 7:55 ` [tip:x86/urgent] x86/speculation/l1tf: Suggest " tip-bot for Vlastimil Babka
2018-08-24 10:36 ` [PATCH] x86/speculation/l1tf: suggest " Vlastimil Babka
2018-08-24 12:10 ` Vlastimil Babka
2018-08-24 12:10 ` Vlastimil Babka
2018-08-24 12:20 ` Michal Hocko
2018-08-24 13:57 ` [tip:x86/urgent] x86/speculation/l1tf: Suggest " tip-bot for Vlastimil Babka
2018-08-23 15:44 ` [PATCH] x86/speculation/l1tf: fix off-by-one error when warning that system has " Andi Kleen
2018-08-23 20:20 ` Vlastimil Babka
2018-08-24 2:22 ` Andre Tomt
2018-08-24 3:35 ` Andi Kleen
2018-08-29 2:04 ` Christopher Snowhill
2018-08-24 8:52 ` xxxxxx xxxxxx
2018-08-24 7:55 ` [tip:x86/urgent] x86/speculation/l1tf: Fix " tip-bot for Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201808240332.3LTpGFNW%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.