All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] qga: ignore non present cpus when handling qmp_guest_get_vcpus()
Date: Fri, 31 Aug 2018 13:22:19 +0200	[thread overview]
Message-ID: <20180831112219.ujfdn4uiya5p7ul4@kamzik.brq.redhat.com> (raw)
In-Reply-To: <38b3347b-8923-26e9-82a4-f69002262767@redhat.com>

On Thu, Aug 30, 2018 at 05:51:13PM +0200, Laszlo Ersek wrote:
> Originally these guest agent commands (both getting and setting) were
> meant to be used in the absence of real VCPU hot[un]plug, as a fallback
> / place-holder.
> 
> If the latter (= real VCPU hot(un)plug) works, then these guest agent
> commands shouldn't be used at all.
> 
> Drew, do I remember correctly?

Yup. This guest agent functionality was merely a stopgap to support "cpu
hotplug", before real cpu hotplug could be supported.

> I wonder if, instead of this patch, we should rework
> qmp_guest_get_vcpus(), to silently skip processors for which this
> dirpath ENOENT condition arises (i.e., return a shorter list of
> GuestLogicalProcessor objects).

That sounds good to me.

Thanks,
drew

  parent reply	other threads:[~2018-08-31 11:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 12:08 [Qemu-devel] [PATCH] qga: ignore non present cpus when handling qmp_guest_get_vcpus() Igor Mammedov
2018-08-30 15:51 ` Laszlo Ersek
2018-08-31  8:00   ` Igor Mammedov
2018-08-31 10:19     ` Laszlo Ersek
2018-09-06  9:00       ` [Qemu-devel] [libvirt] " Peter Krempa
2018-08-31 11:22   ` Andrew Jones [this message]
2018-09-05  0:12     ` [Qemu-devel] " Michael Roth
2018-09-06  9:49   ` Igor Mammedov
2018-09-06 10:26     ` Laszlo Ersek
2018-09-06 10:50       ` Igor Mammedov
2018-09-06 11:52         ` Laszlo Ersek
2018-09-06 12:00           ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831112219.ujfdn4uiya5p7ul4@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.