From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 06/12] ASoC: SOF: Add support for loading topologies
Date: Mon, 3 Sep 2018 17:19:11 +0100 [thread overview]
Message-ID: <20180903161911.GR10302@sirena.org.uk> (raw)
In-Reply-To: <20180831151910.16122-7-liam.r.girdwood@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 754 bytes --]
On Fri, Aug 31, 2018 at 04:19:04PM +0100, Liam Girdwood wrote:
> +static int sof_widget_load(struct snd_soc_component *scomp, int index,
> + struct snd_soc_dapm_widget *w,
> + struct snd_soc_tplg_dapm_widget *tw)
> +{
> + /* nothing todo atm */
> + return 0;
> +}
> +static int sof_link_unload(struct snd_soc_component *scomp,
> + struct snd_soc_dobj *dobj)
> +{
> + return 0;
> +}
Missing implementation here as well? If these functions can sensibly be
optional shouldn't the framework support that?
> +static int sof_route_unload(struct snd_soc_component *scomp,
> + struct snd_soc_dobj *dobj)
> +{
> + /* TODO: unload routes when topology is changed */
> + return 0;
> +}
This seems like it should at least return an error.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-09-03 16:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 15:18 [PATCH v2 00/12] Sound Open Firmware Core Liam Girdwood
2018-08-31 15:18 ` [PATCH v2 01/12] ASoC: SOF: Add Sound Open Firmware driver core Liam Girdwood
2018-09-03 15:07 ` Mark Brown
2018-08-31 15:19 ` [PATCH v2 02/12] ASoC: SOF: Add Sound Open Firmware KControl support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 03/12] ASoC: SOF: Add driver debug support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 04/12] ASoC: SOF: Add support for IPC IO between DSP and Host Liam Girdwood
2018-09-03 15:53 ` Mark Brown
2018-09-04 13:15 ` Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 05/12] ASoC: SOF: Add PCM operations support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 06/12] ASoC: SOF: Add support for loading topologies Liam Girdwood
2018-09-03 16:19 ` Mark Brown [this message]
2018-08-31 15:19 ` [PATCH v2 07/12] ASoC: SOF: Add DSP firmware trace event support Liam Girdwood
2018-09-03 16:25 ` Mark Brown
2018-09-04 13:21 ` Liam Girdwood
2018-09-04 15:03 ` Mark Brown
2018-09-04 15:28 ` Liam Girdwood
2018-09-04 15:46 ` Mark Brown
2018-09-20 16:02 ` Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 08/12] ASoC: SOF: Add DSP HW abstraction operations Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 09/12] ASoC: SOF: Add firmware loader support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 10/12] ASoC: SOF: Add PM support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 11/12] ASoC: SOF: Add userspace ABI support Liam Girdwood
2018-08-31 15:19 ` [PATCH v2 12/12] ASoC: SOF: Add Build support for SOF core Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903161911.GR10302@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.