From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Date: Mon, 3 Sep 2018 18:26:52 +0200 Message-ID: <20180903162652.GI21634@phenom.ffwll.local> References: <20180903074315.GB21634@phenom.ffwll.local> <1705932.lAR3QV8q47@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1705932.lAR3QV8q47@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Alex Deucher , Thierry Reding , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Airlie , Maxime Ripard , Jonathan Hunter , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Gerd Hoffmann List-Id: linux-tegra@vger.kernel.org T24gTW9uLCBTZXAgMDMsIDIwMTggYXQgMDE6MzE6MzRQTSArMDIwMCwgQmFydGxvbWllaiBab2xu aWVya2lld2ljeiB3cm90ZToKPiBPbiBNb25kYXksIFNlcHRlbWJlciAwMywgMjAxOCAwOTo0Mzox NSBBTSBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gT24gU2F0LCBTZXAgMDEsIDIwMTggYXQgMDQ6 MDg6NDFQTSArMDIwMCwgTWljaGHFgiBNaXJvc8WCYXcgd3JvdGU6Cj4gPiA+IFRoaXMgc2VyaWVz IGNsZWFucyB1cCBkdXBsaWNhdGVkIGNvZGUgZm9yIHJlcGxhY2luZyBmaXJtd2FyZSBGQgo+ID4g PiBkcml2ZXIgd2l0aCBwcm9wZXIgRFJJIGRyaXZlciBhbmQgYWRkcyBoYW5kb3ZlciBzdXBwb3J0 IHRvCj4gPiA+IFRlZ3JhIGRyaXZlci4KPiA+ID4gCj4gPiA+IFRoaXMgaXMgYSBzbGlndGx5IHVw ZGF0ZWQgdmVyc2lvbiBvZiBhIHNlcmllcyBzZW50IG9uIDI0IE5vdiAyMDE3Lgo+ID4gPiAKPiA+ ID4gLS0tCj4gPiA+IHYyOgo+ID4gPiAgLSByZWJhc2VkIG9uIGN1cnJlbnQgZHJtLW5leHQKPiA+ ID4gIC0gZHJvcHBlZCBzdGFnaW5nL3NtNzUwZmIgY2hhbmdlcwo+ID4gPiAgLSBhZGRlZCBrZXJu ZWwgZG9jcyBmb3IgRFJNIGhlbHBlcnMKPiA+ID4gdjM6Cj4gPiA+ICAtIG1vdmUga2VybmVsZG9j IHRvIGZiZGV2LCB3aGVyZSBmdW5jdGlvbnMgYXJlIGltcGxlbWVudGVkCj4gPiA+ICAtIHNwbGl0 IGtlcm5lbGRvYyBmb3IgcmVtb3ZlX2NvbmZsaWN0aW5nX2ZyYW1lYnVmZmVycygpCj4gPiAKPiA+ IEFoLCB0aGF0J3Mgbm90IHF1aXRlIHdoYXQgSSBoYWQgaW4gbWluZC4gSSB0aGluayBoYXZpbmcg dGhlIGRvY3MgKGFsc28pIGluCj4gPiB0aGUgZHJtIGhlbHBlcnMgd291bGQgYmUgZ29vZCwgc2lu Y2UgdGhhdCdzIHdoZXJlIGRybSBwZW9wbGUgd2lsbCBsb29rLAo+ID4gYW5kIHRoYXQncyB0aGUg ZnVuY3Rpb24gdGhleSdsbCBjYWxsLiBJIGp1c3Qgd2FudGVkIHlvdSB0byBzcGxpdCB0aGUgZmJk ZXYKPiA+IGFuZCBkcm0gcGFydHMgaW50byAyIHBhdGNoZXMgKHNpbmNlIHRob3NlIGFyZSB0d28g ZGlmZmVyZW50IG1haW50YWluZXJzKS4KPiA+IAo+ID4gQW55d2F5LCB0aGlzIGlzIG9rIHRvbywg c28gaW1vIHJlYWR5IGZvciBtZXJnaW5nLiBJZiB5b3UgY2FuIHJlc3VycmVjdCB0aGUKPiA+IGRy bSBkb2NzICh3aXRoIGEgcGF0Y2ggdGl0bGUgb2YgImRybS9mYi1oZWxwZXI6IGRvY3VtZW50IGZi ZGV2IHJlbW92ZQo+ID4gZnVuY3Rpb25zIiBvciBzaW1pbGFyKSB0aGF0IHdvdWxkIGJlIGdyZWF0 Lgo+ID4gCj4gPiBPbmx5IHRoaW5nIHdlIG5lZWQgZm9yIG1lcmdpbmcgbm93IGlzIHRoZSBhY2sg ZnJvbSBCYXJ0bG9taWVqLgo+IAo+IEZvciB0aGUgd2hvbGUgcGF0Y2hzZXQ6Cj4gCj4gQWNrZWQt Ynk6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4K ClRoYW5rcywgZW50aXJlIHBhdGNoIHNldCBhcHBsaWVkIHRvIGRybS1taXNjLW5leHQgZm9yIDQu MjAuCi1EYW5pZWwKCj4gCj4gPiAtRGFuaWVsCj4gPiAKPiA+ID4gIC0gcHJvcGFnYXRlIHJldHVy biB2YWx1ZSBpbiByZW1vdmVfY29uZmxpY3RpbmdfcGNpX2ZyYW1lYnVmZmVycygpCj4gPiA+IAo+ ID4gPiAtLS0KPiA+ID4gTWljaGHFgiBNaXJvc8WCYXcgKDEzKToKPiA+ID4gICBmYmRldjogc2hv dyBmYmRldiBudW1iZXIgZm9yIGRlYnVnZ2luZwo+ID4gPiAgIGZiZGV2OiBhbGxvdyBhcGVydHVy ZXMgPT0gTlVMTCBpbiByZW1vdmVfY29uZmxpY3RpbmdfZnJhbWVidWZmZXJzKCkKPiA+ID4gICBm YmRldjogYWRkIGtlcm5lbGRvYyBkbyByZW1vdmVfY29uZmxpY3RpbmdfZnJhbWVidWZmZXJzKCkK PiA+ID4gICBmYmRldjogYWRkIHJlbW92ZV9jb25mbGljdGluZ19wY2lfZnJhbWVidWZmZXJzKCkK PiA+ID4gICBkcm0vYW1kZ3B1OiB1c2Ugc2ltcGxlciByZW1vdmVfY29uZmxpY3RpbmdfcGNpX2Zy YW1lYnVmZmVycygpCj4gPiA+ICAgZHJtL2JvY2hzOiB1c2Ugc2ltcGxlciByZW1vdmVfY29uZmxp Y3RpbmdfcGNpX2ZyYW1lYnVmZmVycygpCj4gPiA+ICAgZHJtL2NpcnJ1czogdXNlIHNpbXBsZXIg cmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1ZmZlcnMoKQo+ID4gPiAgIGRybS9tZ2FnMjAw OiB1c2Ugc2ltcGxlciByZW1vdmVfY29uZmxpY3RpbmdfcGNpX2ZyYW1lYnVmZmVycygpCj4gPiA+ ICAgZHJtL3JhZGVvbjogdXNlIHNpbXBsZXIgcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1 ZmZlcnMoKQo+ID4gPiAgIGRybS92aXJ0aW86IHVzZSBzaW1wbGVyIHJlbW92ZV9jb25mbGljdGlu Z19wY2lfZnJhbWVidWZmZXJzKCkKPiA+ID4gICBkcm0vdmM0OiB1c2Ugc2ltcGxlciByZW1vdmVf Y29uZmxpY3RpbmdfZnJhbWVidWZmZXJzKE5VTEwpCj4gPiA+ICAgZHJtL3N1bjRpOiB1c2Ugc2lt cGxlciByZW1vdmVfY29uZmxpY3RpbmdfZnJhbWVidWZmZXJzKE5VTEwpCj4gPiA+ICAgZHJtL3Rl Z3JhOiBraWNrIG91dCBzaW1wbGVmYgo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9kcnYuYyAgfCAyNCArLS0tLS0tLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9ib2Nocy9ib2Noc19kcnYuYyAgICAgICAgfCAxOCArLS0tLS0tCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vY2lycnVzL2NpcnJ1c19kcnYuYyAgICAgIHwgMjMgKy0tLS0tLS0tCj4gPiA+ICBkcml2 ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2Rydi5jICAgIHwgMjEgKy0tLS0tLS0KPiA+ID4g IGRyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfbWFpbi5jICAgfCAgOSAtLS0tCj4gPiA+ ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYyAgICAgIHwgMjMgKy0tLS0tLS0t Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfZHJ2LmMgICAgICAgIHwgMTggKy0t LS0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RybS5jICAgICAgICAgICAgICB8ICA0 ICsrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuYyAgICAgICAgICAgIHwgMjAg Ky0tLS0tLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9kcm1fYnVzLmMg fCAyNCArKy0tLS0tLS0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYm1lbS5jICAg ICAgICAgfCA2MyArKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ID4gIGluY2x1ZGUvZHJtL2Ry bV9mYl9oZWxwZXIuaCAgICAgICAgICAgICAgfCAxMiArKysrKwo+ID4gPiAgaW5jbHVkZS9saW51 eC9mYi5oICAgICAgICAgICAgICAgICAgICAgICB8ICAyICsKPiA+ID4gIDEzIGZpbGVzIGNoYW5n ZWQsIDg5IGluc2VydGlvbnMoKyksIDE3MiBkZWxldGlvbnMoLSkKPiAKPiBCZXN0IHJlZ2FyZHMs Cj4gLS0KPiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6Cj4gU2Ftc3VuZyBSJkQgSW5zdGl0dXRl IFBvbGFuZAo+IFNhbXN1bmcgRWxlY3Ryb25pY3MKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxp bmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Mon, 03 Sep 2018 16:26:52 +0000 Subject: Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Message-Id: <20180903162652.GI21634@phenom.ffwll.local> List-Id: References: <20180903074315.GB21634@phenom.ffwll.local> <1705932.lAR3QV8q47@amdc3058> In-Reply-To: <1705932.lAR3QV8q47@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Alex Deucher , Thierry Reding , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Airlie , Maxime Ripard , Jonathan Hunter , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Gerd Hoffmann On Mon, Sep 03, 2018 at 01:31:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > > > This series cleans up duplicated code for replacing firmware FB > > > driver with proper DRI driver and adds handover support to > > > Tegra driver. > > > > > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > > > > > --- > > > v2: > > > - rebased on current drm-next > > > - dropped staging/sm750fb changes > > > - added kernel docs for DRM helpers > > > v3: > > > - move kerneldoc to fbdev, where functions are implemented > > > - split kerneldoc for remove_conflicting_framebuffers() > > > > Ah, that's not quite what I had in mind. I think having the docs (also) in > > the drm helpers would be good, since that's where drm people will look, > > and that's the function they'll call. I just wanted you to split the fbdev > > and drm parts into 2 patches (since those are two different maintainers). > > > > Anyway, this is ok too, so imo ready for merging. If you can resurrect the > > drm docs (with a patch title of "drm/fb-helper: document fbdev remove > > functions" or similar) that would be great. > > > > Only thing we need for merging now is the ack from Bartlomiej. > > For the whole patchset: > > Acked-by: Bartlomiej Zolnierkiewicz Thanks, entire patch set applied to drm-misc-next for 4.20. -Daniel > > > -Daniel > > > > > - propagate return value in remove_conflicting_pci_framebuffers() > > > > > > --- > > > Michał Mirosław (13): > > > fbdev: show fbdev number for debugging > > > fbdev: allow apertures = NULL in remove_conflicting_framebuffers() > > > fbdev: add kerneldoc do remove_conflicting_framebuffers() > > > fbdev: add remove_conflicting_pci_framebuffers() > > > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > > > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > > > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > > > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > > > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > > > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > > > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > > > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > > > drm/tegra: kick out simplefb > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +-------- > > > drivers/gpu/drm/bochs/bochs_drv.c | 18 +------ > > > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-------- > > > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------- > > > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ---- > > > drivers/gpu/drm/radeon/radeon_drv.c | 23 +-------- > > > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +------ > > > drivers/gpu/drm/tegra/drm.c | 4 ++ > > > drivers/gpu/drm/vc4/vc4_drv.c | 20 +------- > > > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------- > > > drivers/video/fbdev/core/fbmem.c | 63 +++++++++++++++++++++++- > > > include/drm/drm_fb_helper.h | 12 +++++ > > > include/linux/fb.h | 2 + > > > 13 files changed, 89 insertions(+), 172 deletions(-) > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Mon, 3 Sep 2018 18:26:52 +0200 Subject: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup In-Reply-To: <1705932.lAR3QV8q47@amdc3058> References: <20180903074315.GB21634@phenom.ffwll.local> <1705932.lAR3QV8q47@amdc3058> Message-ID: <20180903162652.GI21634@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 03, 2018 at 01:31:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Micha? Miros?aw wrote: > > > This series cleans up duplicated code for replacing firmware FB > > > driver with proper DRI driver and adds handover support to > > > Tegra driver. > > > > > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > > > > > --- > > > v2: > > > - rebased on current drm-next > > > - dropped staging/sm750fb changes > > > - added kernel docs for DRM helpers > > > v3: > > > - move kerneldoc to fbdev, where functions are implemented > > > - split kerneldoc for remove_conflicting_framebuffers() > > > > Ah, that's not quite what I had in mind. I think having the docs (also) in > > the drm helpers would be good, since that's where drm people will look, > > and that's the function they'll call. I just wanted you to split the fbdev > > and drm parts into 2 patches (since those are two different maintainers). > > > > Anyway, this is ok too, so imo ready for merging. If you can resurrect the > > drm docs (with a patch title of "drm/fb-helper: document fbdev remove > > functions" or similar) that would be great. > > > > Only thing we need for merging now is the ack from Bartlomiej. > > For the whole patchset: > > Acked-by: Bartlomiej Zolnierkiewicz Thanks, entire patch set applied to drm-misc-next for 4.20. -Daniel > > > -Daniel > > > > > - propagate return value in remove_conflicting_pci_framebuffers() > > > > > > --- > > > Micha? Miros?aw (13): > > > fbdev: show fbdev number for debugging > > > fbdev: allow apertures == NULL in remove_conflicting_framebuffers() > > > fbdev: add kerneldoc do remove_conflicting_framebuffers() > > > fbdev: add remove_conflicting_pci_framebuffers() > > > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > > > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > > > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > > > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > > > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > > > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > > > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > > > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > > > drm/tegra: kick out simplefb > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +-------- > > > drivers/gpu/drm/bochs/bochs_drv.c | 18 +------ > > > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-------- > > > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------- > > > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ---- > > > drivers/gpu/drm/radeon/radeon_drv.c | 23 +-------- > > > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +------ > > > drivers/gpu/drm/tegra/drm.c | 4 ++ > > > drivers/gpu/drm/vc4/vc4_drv.c | 20 +------- > > > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------- > > > drivers/video/fbdev/core/fbmem.c | 63 +++++++++++++++++++++++- > > > include/drm/drm_fb_helper.h | 12 +++++ > > > include/linux/fb.h | 2 + > > > 13 files changed, 89 insertions(+), 172 deletions(-) > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch