All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@arm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: <acme@kernel.org>, <jolsa@kernel.org>, <adrian.hunter@intel.com>,
	<linux-kernel@vger.kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 6/8] perf, tools, script: Make itrace script default to all calls
Date: Tue, 4 Sep 2018 14:38:36 -0500	[thread overview]
Message-ID: <20180904143836.43f1c07134e25bda6fa0842c@arm.com> (raw)
In-Reply-To: <20180903162249.36304-7-andi@firstfloor.org>

On Mon, 3 Sep 2018 09:22:47 -0700
Andi Kleen <andi@firstfloor.org> wrote:

<snip>
> Fix ETM build failure
> ---
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 2ae640257fdb..0296405f38b2 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -1432,7 +1432,8 @@ int cs_etm__process_auxtrace_info(union perf_event *event,
>  	if (session->itrace_synth_opts && session->itrace_synth_opts->set) {
>  		etm->synth_opts = *session->itrace_synth_opts;
>  	} else {
> -		itrace_synth_opts__set_default(&etm->synth_opts);
> +		itrace_synth_opts__set_default(&etm->synth_opts,
> +				etm->synth_opts->default_no_sample);

This still fails but with a different error:

  CC       util/cs-etm.o
util/cs-etm.c: In function ‘cs_etm__process_auxtrace_info’:
util/cs-etm.c:1436:20: error: invalid type argument of ‘->’ (have ‘struct itrace_synth_opts’)
     etm->synth_opts->default_no_sample);
                    ^~

I tried this diff, and it built:

diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 0296405f38b2..3b37d66dc533 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -1433,7 +1433,7 @@ int cs_etm__process_auxtrace_info(union perf_event *event,
                etm->synth_opts = *session->itrace_synth_opts;
        } else {
                itrace_synth_opts__set_default(&etm->synth_opts,
-                               etm->synth_opts->default_no_sample);
+                               session->itrace_synth_opts->default_no_sample);
                etm->synth_opts.callchain = false;
        }
 
So please incorporate it in this patch.

FYI, building-in cs-etm decoding into perf depends on
CONFIG_LIBOPENCSD.  Debian has a package 'libopencsd' that provides
it.  I don't know about other distros, but it's possible to build and
install the library from scratch:

https://github.com/Linaro/OpenCSD/

Thanks,

Kim

  reply	other threads:[~2018-09-04 19:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 16:22 Make perf script easier to use for itrace Andi Kleen
2018-09-03 16:22 ` [PATCH v4 1/8] perf tools: Report itrace options in help Andi Kleen
2018-09-03 16:22 ` [PATCH v4 2/8] tools, pager: Support overwriting the pager Andi Kleen
2018-09-03 16:22 ` [PATCH v4 3/8] tools, perf, script: Add --insn-trace for instruction decoding Andi Kleen
2018-09-03 16:22 ` [PATCH v4 4/8] perf, tools, script: Allow sym and dso without ip, addr Andi Kleen
2018-09-03 16:22 ` [PATCH v4 5/8] perf, tools, script: Print DSO for callindent Andi Kleen
2018-09-03 16:22 ` [PATCH v4 6/8] perf, tools, script: Make itrace script default to all calls Andi Kleen
2018-09-04 19:38   ` Kim Phillips [this message]
2018-09-03 16:22 ` [PATCH v4 7/8] tools, perf, script: Add --call-trace and --call-ret-trace Andi Kleen
2018-09-03 16:22 ` [PATCH v4 8/8] tools, perf, script: Implement --graph-function Andi Kleen
2018-09-14  3:10 Make perf script easier to use for itrace Andi Kleen
2018-09-14  3:10 ` [PATCH v4 6/8] perf, tools, script: Make itrace script default to all calls Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904143836.43f1c07134e25bda6fa0842c@arm.com \
    --to=kim.phillips@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.