From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2]: perf record: enable asynchronous trace writing
Date: Thu, 6 Sep 2018 13:04:23 +0200 [thread overview]
Message-ID: <20180906110423.GH8248@krava> (raw)
In-Reply-To: <dc18a621-4464-e5a5-ce10-5f7b2f6a9176@linux.intel.com>
On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote:
SNIP
> + } else if (errno != EAGAIN) {
> + cblock->aio_fildes = -1;
> + pr_err("failed to queue perf data, error: %m\n");
> + break;
> + }
> + } while (1);
> +
> + return rc;
> +}
> +
> +static int record__aio_sync(struct perf_mmap *md)
> +{
this is almost identical to record__aio_sync function,
it looks like we should be able to do the sync with
single function.. for both the in-between syncs and
the final one
jirka
next prev parent reply other threads:[~2018-09-06 11:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:16 [PATCH v7 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-09-05 7:19 ` [PATCH v7 1/2]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:50 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:54 ` Alexey Budankov
2018-09-05 7:39 ` [PATCH v7 2/2]: perf record: enable asynchronous trace writing Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:57 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:58 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:59 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa [this message]
2018-09-06 12:09 ` Alexey Budankov
2018-09-05 11:28 ` [PATCH v7 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads Jiri Olsa
2018-09-05 17:37 ` Alexey Budankov
2018-09-05 18:51 ` Arnaldo Carvalho de Melo
2018-09-06 6:03 ` Alexey Budankov
2018-09-06 8:14 ` Jiri Olsa
2018-09-06 8:20 ` Alexey Budankov
2018-09-06 6:59 ` Alexey Budankov
2018-09-06 6:57 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906110423.GH8248@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.