Hi David, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/David-Howells/UAPI-drm-Fix-use-of-C-keywords-as-structural-members-ver-2/20180907-092121 config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): In file included from test.h:225:0, from test.cpp:1: >> ../usr/include/linux/patchkey.h:15:2: error: #error "patchkey.h included directly" #error "patchkey.h included directly" ^~~~~ In file included from ../usr/include/asm/shmbuf.h:6:0, from test.h:83, from test.cpp:1: >> ../usr/include/asm-generic/shmbuf.h:26:20: error: field 'shm_perm' has incomplete type 'ipc64_perm' struct ipc64_perm shm_perm; /* operation perms */ ^~~~~~~~ ../usr/include/asm-generic/shmbuf.h:26:9: note: forward declaration of 'struct ipc64_perm' struct ipc64_perm shm_perm; /* operation perms */ ^~~~~~~~~~ In file included from ../usr/include/asm/msgbuf.h:6:0, from test.h:112, from test.cpp:1: >> ../usr/include/asm-generic/msgbuf.h:25:20: error: field 'msg_perm' has incomplete type 'ipc64_perm' struct ipc64_perm msg_perm; ^~~~~~~~ In file included from ../usr/include/asm/shmbuf.h:6:0, from test.h:83, from test.cpp:1: ../usr/include/asm-generic/shmbuf.h:26:9: note: forward declaration of 'struct ipc64_perm' struct ipc64_perm shm_perm; /* operation perms */ ^~~~~~~~~~ In file included from test.h:868:0, from test.cpp:1: ../usr/include/sound/skl-tplg-interface.h:146:2: error: 'u32' does not name a type; did you mean '__u32'? u32 set_params:2; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:147:2: error: 'u32' does not name a type; did you mean '__u32'? u32 rsvd:30; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:148:2: error: 'u32' does not name a type; did you mean '__u32'? u32 param_id; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:149:2: error: 'u32' does not name a type; did you mean '__u32'? u32 max; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:166:2: error: 'u16' does not name a type; did you mean '__u16'? u16 module_id; ^~~ __u16 ../usr/include/sound/skl-tplg-interface.h:167:2: error: 'u16' does not name a type; did you mean '__u16'? u16 instance_id; ^~~ __u16 ../usr/include/sound/skl-tplg-interface.h:171:2: error: 'u32' does not name a type; did you mean '__u32'? u32 channels; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:172:2: error: 'u32' does not name a type; did you mean '__u32'? u32 freq; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:173:2: error: 'u32' does not name a type; did you mean '__u32'? u32 bit_depth; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:174:2: error: 'u32' does not name a type; did you mean '__u32'? u32 valid_bit_depth; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:175:2: error: 'u32' does not name a type; did you mean '__u32'? u32 ch_cfg; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:176:2: error: 'u32' does not name a type; did you mean '__u32'? u32 interleaving_style; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:177:2: error: 'u32' does not name a type; did you mean '__u32'? u32 sample_type; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:178:2: error: 'u32' does not name a type; did you mean '__u32'? u32 ch_map; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:182:2: error: 'u32' does not name a type; did you mean '__u32'? u32 set_params:2; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:183:2: error: 'u32' does not name a type; did you mean '__u32'? u32 rsvd:30; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:184:2: error: 'u32' does not name a type; did you mean '__u32'? u32 param_id; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:185:2: error: 'u32' does not name a type; did you mean '__u32'? u32 caps_size; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:186:2: error: 'u32' does not name a type; did you mean '__u32'? u32 caps[HDA_SST_CFG_MAX]; ^~~ __u32 ../usr/include/sound/skl-tplg-interface.h:190:2: error: 'u8' does not name a type; did you mean '__u8'? u8 pipe_id; ^~ __u8 ../usr/include/sound/skl-tplg-interface.h:191:2: error: 'u8' does not name a type; did you mean '__u8'? u8 pipe_priority; ^~ __u8 ../usr/include/sound/skl-tplg-interface.h:192:2: error: 'u16' does not name a type; did you mean '__u16'? u16 conn_type:4; ^~~ __u16 ../usr/include/sound/skl-tplg-interface.h:193:2: error: 'u16' does not name a type; did you mean '__u16'? u16 rsvd:4; -- >> find: '../usr/include': No such file or directory In file included from test.cpp:1:0: >> test.h:8:10: fatal error: linux/types.h: No such file or directory #include ^~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [headers_install] Error 1 make: *** [sub-make] Error 2 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation