From: Jeff Cody <jcody@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames
Date: Wed, 12 Sep 2018 08:42:15 -0400 [thread overview]
Message-ID: <20180912124215.GT22117@localhost.localdomain> (raw)
In-Reply-To: <20180912103856.GC5846@localhost.localdomain>
On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > Once we load the image, will the header get rewritten into a compliant
> > > format?
> >
> > Hmm - I think in some code paths, but not all. I don't think the answer is
> > 'yes' universally, alas.
>
> Can't we explicitly call BdrvChildRole.update_filename() for all parents
> when we open a legacy filename? We'd just need to add the callback to
> child_file, which would propagate it to the parents of the format layer,
> and then just opening the image with a legacy backing file link once
> would fix the problem for this image.
>
Yes, that is a good idea. I will spin a v5 with that added.
next prev parent reply other threads:[~2018-09-12 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 5:15 [Qemu-devel] [PATCH 0/2] block/rbd: enable filename parsing on open Jeff Cody
2018-09-11 5:15 ` [Qemu-devel] [PATCH 1/2] block/rbd: pull out qemu_rbd_convert_options Jeff Cody
2018-09-11 17:50 ` Eric Blake
2018-09-11 18:06 ` John Snow
2018-09-11 5:15 ` [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames Jeff Cody
2018-09-11 17:53 ` Jeff Cody
2018-09-11 18:03 ` Eric Blake
2018-09-11 18:28 ` Jeff Cody
2018-09-11 18:22 ` John Snow
2018-09-11 18:37 ` Jeff Cody
2018-09-11 18:39 ` John Snow
2018-09-12 10:38 ` Kevin Wolf
2018-09-12 12:42 ` Jeff Cody [this message]
2018-09-12 12:49 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912124215.GT22117@localhost.localdomain \
--to=jcody@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.