All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jens Axboe <axboe@kernel.dk>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: linux-next: build warning after merge of the block tree
Date: Thu, 27 Sep 2018 23:43:19 -0700	[thread overview]
Message-ID: <20180928064319.GD29754@vader> (raw)
In-Reply-To: <20180928111124.745bf2ef@canb.auug.org.au>

On Fri, Sep 28, 2018 at 11:11:24AM +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
>   [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
>                       ^
> 
> Introduced by commit
> 
>   6e25cb01ea20 ("kyber: implement improved heuristics")

Ugh, thanks for the report. This should fix it:

diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
index 2b62e362fb36..eccac01a10b6 100644
--- a/block/kyber-iosched.c
+++ b/block/kyber-iosched.c
@@ -79,9 +79,9 @@ static const unsigned int kyber_depth[] = {
  * Default latency targets for each scheduling domain.
  */
 static const u64 kyber_latency_targets[] = {
-	[KYBER_READ] = 2 * NSEC_PER_MSEC,
-	[KYBER_WRITE] = 10 * NSEC_PER_MSEC,
-	[KYBER_DISCARD] = 5 * NSEC_PER_SEC,
+	[KYBER_READ] = 2ULL * NSEC_PER_MSEC,
+	[KYBER_WRITE] = 10ULL * NSEC_PER_MSEC,
+	[KYBER_DISCARD] = 5ULL * NSEC_PER_SEC,
 };
 
 /*

Jens, do you mind folding that in, or should I send it separately?

  reply	other threads:[~2018-09-28  6:43 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  1:11 linux-next: build warning after merge of the block tree Stephen Rothwell
2018-09-28  6:43 ` Omar Sandoval [this message]
2018-09-28 14:26   ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2023-06-06  4:00 Stephen Rothwell
2023-03-15  1:48 Stephen Rothwell
2023-03-15  1:54 ` Jens Axboe
2023-02-09  3:00 Stephen Rothwell
2023-01-18  3:10 Stephen Rothwell
2022-10-05  7:17 Stephen Rothwell
2022-10-05 12:19 ` Jens Axboe
2022-07-20  3:33 Stephen Rothwell
2022-07-20 12:10 ` Stephen Rothwell
2022-07-20 12:43 ` Jens Axboe
2022-07-15 12:06 Stephen Rothwell
2022-07-15  3:52 Stephen Rothwell
2022-07-15 12:33 ` Stephen Rothwell
2022-07-15 13:08   ` Dylan Yudaken
2022-04-21  2:02 Stephen Rothwell
2022-04-21  2:03 ` Jens Axboe
2022-04-21  5:43 ` Stephen Rothwell
2021-10-19  5:39 Stephen Rothwell
2021-08-13  9:41 Stephen Rothwell
2021-08-13 13:54 ` Jens Axboe
2021-09-03  6:49   ` Stephen Rothwell
2021-09-03 13:41     ` Jens Axboe
2021-06-15  2:13 Stephen Rothwell
2021-06-15 12:22 ` Pavel Begunkov
2021-06-09  3:52 Stephen Rothwell
2021-06-09  4:28 ` Dan Williams
2021-02-24  2:31 Stephen Rothwell
2021-02-24  2:40 ` Chaitanya Kulkarni
2021-02-24  5:25 ` Chaitanya Kulkarni
2021-02-24  5:33   ` Stephen Rothwell
2021-02-24  5:38     ` Chaitanya Kulkarni
2021-02-24 10:42       ` Stephen Rothwell
2021-02-24 21:41         ` Chaitanya Kulkarni
2021-02-24 21:45           ` Randy Dunlap
2021-02-24 21:51             ` Chaitanya Kulkarni
2021-02-24  7:16     ` Chaitanya Kulkarni
2020-12-22 23:47 Stephen Rothwell
2020-12-23  0:13 ` Jens Axboe
2020-12-07  7:48 Stephen Rothwell
2020-12-03  7:39 Stephen Rothwell
2020-12-14 20:14 ` Stephen Rothwell
2020-12-21  1:30   ` Stephen Rothwell
2020-12-03  7:37 Stephen Rothwell
2020-12-14 20:13 ` Stephen Rothwell
2020-12-21  1:29   ` Stephen Rothwell
2020-11-12  4:32 Stephen Rothwell
2020-10-22 23:48 Stephen Rothwell
2020-10-23  0:30 ` Jens Axboe
2020-07-02  1:21 Stephen Rothwell
2020-07-02  4:07 ` Jens Axboe
2020-03-04  2:17 Stephen Rothwell
2020-03-04  3:01 ` Jens Axboe
2020-03-04 12:50   ` Pavel Begunkov
2020-01-31  0:16 Stephen Rothwell
2020-01-31  0:25 ` Jens Axboe
2020-01-16  0:54 Stephen Rothwell
2020-01-16  4:50 ` Jens Axboe
2019-10-18  0:51 Stephen Rothwell
2019-10-18  0:56 ` Jens Axboe
2019-10-18  0:59   ` Jens Axboe
2019-10-18  3:58   ` Stephen Rothwell
2019-08-29  3:51 Stephen Rothwell
2019-08-29  4:08 ` Stephen Rothwell
2019-08-29 15:41   ` Tejun Heo
2019-08-29 15:44     ` Jens Axboe
2019-08-09  4:00 Stephen Rothwell
2019-08-09  4:13 ` Jens Axboe
2019-08-09  6:15 ` Yuehaibing
2019-04-17  2:31 Stephen Rothwell
2019-04-17 10:05 ` Chao Yu
2019-04-17 14:03   ` Jaegeuk Kim
2019-04-18  0:57     ` Chao Yu
2019-04-18 14:01       ` Jaegeuk Kim
2019-04-19  1:14         ` Chao Yu
2018-11-08  3:31 Stephen Rothwell
2018-11-08  4:19 ` Jens Axboe
2018-05-31  3:49 Stephen Rothwell
2018-05-14  2:51 Stephen Rothwell
2018-05-14  8:29 ` Christoph Hellwig
2018-05-14 14:31   ` Jens Axboe
2017-05-10  1:24 Stephen Rothwell
2017-05-10  2:20 ` Markus Trippelsdorf
2017-05-10  3:00   ` Jens Axboe
2017-05-10  6:19     ` Markus Trippelsdorf
2017-05-10  3:26   ` Stephen Rothwell
2014-10-23  1:28 Stephen Rothwell
2014-10-23  2:14 ` Jens Axboe
2013-09-23  4:29 Stephen Rothwell
2011-05-09  3:49 Stephen Rothwell
2011-05-09  5:55 ` Tao Ma
2011-05-09  6:34   ` Jens Axboe
2010-12-20  4:31 Stephen Rothwell
2010-12-20  4:42 ` Stephen Rothwell
2010-12-20  8:12   ` Jens Axboe
2010-09-16  3:30 Stephen Rothwell
2010-04-29  6:14 Stephen Rothwell
2010-04-29  7:28 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928064319.GD29754@vader \
    --to=osandov@osandov.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.