From: Himanshu Jha <himanshujha199640@gmail.com>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com, abbotti@mev.co.uk,
gregkh@linuxfoundation.org, hsweeten@visionengravers.com
Subject: Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
Date: Sun, 7 Oct 2018 01:01:51 +0530 [thread overview]
Message-ID: <20181006193150.GA8922@himanshu-Vostro-3559> (raw)
In-Reply-To: <20181006190246.GA14037@veda-VGN-CS3AGH-R>
On Sun, Oct 07, 2018 at 12:32:47AM +0530, Bhanusree Pola wrote:
> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>
> changes in v5:
> -Fixed Change log
> -Change in subject line.Do not send as 'Re:'
>
> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
> to fix checkpatch Error.
>
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
> Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
>
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds
> 75 characters per line. Adjust to 75 chars to improve
> readability and also adjust the arguments to match open
> parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
> characters. Modified contents to adjust 75 chars per line.
>
> drivers/staging/comedi/comedi_pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
> struct pci_driver *pci_driver);
>
> /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
The original line is:
* module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/comedi/comedi_pci.h#n44
The patch looks dubious to me.
Always base your work on latest -next tree.
https://www.kernel.org/doc/man-pages/linux-next.html
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
next prev parent reply other threads:[~2018-10-06 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 19:02 [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
2018-10-06 19:06 ` [Outreachy kernel] " Julia Lawall
2018-10-06 19:13 ` Bhanusree
2018-10-06 19:31 ` Himanshu Jha [this message]
2018-10-06 19:41 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006193150.GA8922@himanshu-Vostro-3559 \
--to=himanshujha199640@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=bhanusreemahesh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.